025281230d
Summary:Motivation: Developer expects `onclose` to be called before/during close of the websocket. The `websocketFailed` event triggers a close but does not invoke onclose. Testplan: Connect to a websocket server from android, terminate the server, observe that onerror is called, the websocket is closed, but onclose is not called. Note: the observed bug is in android only because in iOS the underlying websocket implementation fires the `websocketClosed` rather than `websocketFailed` event when the server terminates. Nevertheless, the justification for this change stands that regardless of the cause of the close, if `this.close` is called it is expected this.onclose should be called as well. Closes https://github.com/facebook/react-native/pull/6307 Differential Revision: D3017458 fb-gh-sync-id: c9e2dfefa597b4e99ee85eaa991667c347f86d83 shipit-source-id: c9e2dfefa597b4e99ee85eaa991667c347f86d83 |
||
|---|---|---|
| .. | ||
| RCTWebSocket.xcodeproj | ||
| __mocks__ | ||
| __tests__ | ||
| RCTSRWebSocket.h | ||
| RCTSRWebSocket.m | ||
| RCTWebSocketExecutor.h | ||
| RCTWebSocketExecutor.m | ||
| RCTWebSocketManager.h | ||
| RCTWebSocketManager.m | ||
| RCTWebSocketModule.h | ||
| RCTWebSocketModule.m | ||
| WebSocket.js | ||
| WebSocketBase.js | ||
| WebSocketEvent.js | ||