react-native/ReactCommon/fabric
Valentin Shergin 80f7891287 Fabric: Embracing non-trivial default values of some Props
Summary:
@public
This is follow up for D8601600 and D8247652 (the last one has detailed explanation of the problem).
From this commit I propose that we have to follow simple rule:
If some prop has a default value which differs from the default value of its type, we have to specify it as {<value>} in .h file and explicitly in .m file, for all other props the default value must not be specified explicitly (in .h files it must be specified as {}).
The reason is that we have to embrase those cases and establish behaviour: if we change the default value in .h file, it always means that we have to change the value in .cpp file too.

Reviewed By: fkgozali

Differential Revision: D8601776

fbshipit-source-id: 3379aace4e2d72febb2b942a3da1cb24decf54be
2018-06-26 11:48:13 -07:00
..
activityindicator Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
attributedstring Fabric: Embracing non-trivial default values of some Props 2018-06-26 11:48:13 -07:00
components Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
core Fabric: `fromDynamic` for float numbers was moved to `core` module 2018-06-26 11:48:12 -07:00
debug Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
graphics Fabric: `fromDynamic` for float numbers was moved to `core` module 2018-06-26 11:48:12 -07:00
imagemanager Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
sample Fabric: Introducing `ContextContainer` 2018-06-22 07:32:49 -07:00
scrollview Fabric: Embracing non-trivial default values of some Props 2018-06-26 11:48:13 -07:00
text Fabric: Embracing non-trivial default values of some Props 2018-06-26 11:48:13 -07:00
textlayoutmanager Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
uimanager iOS: implement <PerformanceLoggerFlag> component 2018-06-24 14:17:37 -07:00
view Fabric: Embracing non-trivial default values of some Props 2018-06-26 11:48:13 -07:00