mirror of https://github.com/status-im/react-native.git synced 2025-02-22 14:18:23 +00:00

History

Haitao Li b0d68c0bb9 Fix DynamicFromMap object pool synchronization (#17842 )

Summary:
DynamicFromMap internally uses SimplePool object to recycle dynamic prop objects. But the pool is not multi-thread safe. Currently the most used dynamic props are size props such as left, paddingVertical, marginTop and so on. These props are only accessed from the layout thread so the pool works fine. If a dynamic prop is needed in UI thread, then the two threads can access the same pool object and cause random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process.

Tested in official Airbnb app after updating accessibilityComponentType to be dynamic.

Once this is merged, I'll send another PR to support "disabled" state in `accessibilityComponentType`.

[ANDROID] [BUGFIX] [DynamicFromMap] - Fix a crash caused by dynamic props.
Pull Request resolved: https://github.com/facebook/react-native/pull/17842

Differential Revision: D10374238

Pulled By: hramos

fbshipit-source-id: 7ebf89c5abf06bd5fb43b205348ba4dc7e19517d

2018-10-13 17:42:44 -07:00

libs

Bump Android Support Library to 27.1.1 (#20586 )

2018-08-20 18:08:52 -07:00

src

Fix DynamicFromMap object pool synchronization (#17842 )

2018-10-13 17:42:44 -07:00

.npmignore

Don't publish /ReactAndroid/build to npm, update version on master

2015-10-12 11:11:40 -07:00

build.gradle

Update to Detox 9 (#21570 )