status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/React
History
Hoa Dinh e11cdc917c Fixed RCTAssert nullability 
Summary:
```
Apps/Instagram/AppLibraries/IGReactKit/IGReactKit/IGReactRouteHelpers.m:54:5: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
    RCTAssert(!(title != nil && logoAsTitle), @"Screen navigationOptions cannot have both title and logoAsTitle.");
    ^
Apps/Instagram/AppLibraries/IGReactKit/IGReactKit/IGReactRouteHelpers.m:54:5: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
/data/sandcastle/boxes/trunk-hg-fbobjc-fbsource/xplat/js/react-native-github/React/Base/RCTAssert.h:28:14: note: expanded from macro 'RCTAssert'
        file:@(__FILE__) lineNumber:__LINE__ description:__VA_ARGS__]; \

```

Reviewed By: zats

Differential Revision: D8509133

fbshipit-source-id: ae7027efc18716193c86fbeeec74d41d1879797f
 		2018-06-18 23:46:15 -07:00
..
Base Fixed RCTAssert nullability 2018-06-18 23:46:15 -07:00
CxxBridge fabric: send events via JS thread 2018-06-15 11:02:17 -07:00
CxxModule Update license headers for MIT license 2018-02-16 18:31:53 -08:00
CxxUtils Update license headers for MIT license 2018-02-16 18:31:53 -08:00
DevSupport Migrate Android sources to MIT license header 2018-05-31 15:37:30 -07:00
Fabric Fabric: Implementation of <View transform={...}/> property 2018-06-15 11:47:40 -07:00
Inspector Migrate Android sources to MIT license header 2018-05-31 15:37:30 -07:00
Modules `Invalid JS responder` error was promoted to warning 2018-06-17 21:46:22 -07:00
Profiler Update license headers for MIT license 2018-02-16 18:31:53 -08:00
React.xcodeproj Revert D8489006: [react-native][PR] Update Xcode projects 2018-06-18 12:18:02 -07:00
UIUtils Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Views Fix or mark enum conversions 2018-05-22 09:53:54 -07:00
third-party.xcconfig OSS: upgrade Folly 2016.09.26 => 2016.10.31 2018-04-13 17:33:23 -07:00