status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Andrew Kriger 722f88ca90 Adds Android click sound to Touchables 
Summary:
Android apps play a touch sound on press, as long as you have "Touch sounds" enabled in the settings. As and Android user, when building my app using React Native, one of the first things I noticed was that there were not any touch sounds. This is missing from React Native and there have been multiple PRs to have this implemented, but no success.

This PR iterates over [#6825](https://github.com/facebook/react-native/pull/6825) and [#11136](https://github.com/facebook/react-native/pull/11136)

This PR keeps it simple by only implementing the enhancement for Android, as iOS apps typically do not use touch sounds, and follows the users' system settings for whether or not the sound is played.

I have manually tested this on multiple devices and emulators with zero problems

[ANDROID] [ENHANCEMENT] [UIManagerModule.java]- Adds Android click sound to touchables

[ANDROID] [ENHANCEMENT] [Touchable] - Adds Android click sound to touchables
Closes https://github.com/facebook/react-native/pull/17183

Differential Revision: D7560327

Pulled By: hramos

fbshipit-source-id: ce1094c437541bc677c7d64b0dba343dd9574422
 		2018-04-09 17:01:57 -07:00
..
ART Update license headers for MIT license 2018-02-16 18:31:53 -08:00
ActionSheetIOS Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Alert Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
Animated Add an implementation of Animated.subtract 2018-03-30 21:08:52 -07:00
AppState Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
BatchedBridge Replace RN exception handling override with new version 2018-04-03 06:01:37 -07:00
Blob Fix blob response parsing for empty body on iOS 2018-03-27 11:13:34 -07:00
BugReporting Update license headers for MIT license 2018-02-16 18:31:53 -08:00
CameraRoll @allow-large-files Upgrade xplat/js to Flow v0.66 2018-02-16 20:24:57 -08:00
Components Adds Android click sound to Touchables 2018-04-09 17:01:57 -07:00
Core Make fetchSegment native hook name consistent with __ prefix 2018-03-09 08:55:51 -08:00
EventEmitter Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Experimental Upgrade to Flow v0.68.0 2018-03-19 18:31:36 -07:00
Geolocation Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
Image Implement Image.defaultSource property on Android 2018-04-06 16:03:00 -07:00
Inspector StyleObj -> DangerouslyImpreciseStyleProp 2018-03-07 13:24:20 -08:00
Interaction Fix TouchHistoryMath import 2018-04-07 21:09:24 -07:00
JSInspector Update license headers for MIT license 2018-02-16 18:31:53 -08:00
LayoutAnimation Add ability for Animated views to be created with scale X or scale Y 2018-04-06 17:46:54 -07:00
Linking Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
LinkingIOS Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Lists Add custom RefreshControl support to VirtualizedList 2018-03-27 18:19:30 -07:00
Modal Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
NativeAnimation Fix tvOS build breakage in RCTAnimation Xcode project 2018-04-02 22:33:45 -07:00
Network Downgrade ES6 import to ES5 compat module.exports 2018-04-05 06:36:53 -07:00
Performance RN: Delete Systrace.swizzleJSON 2018-03-08 23:43:26 -08:00
PermissionsAndroid Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
PushNotificationIOS Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
RCTTest Update license headers for MIT license 2018-02-16 18:31:53 -08:00
ReactNative Move takeSnapshot from React repo to RN 2018-04-07 23:23:33 -07:00
Renderer Move takeSnapshot from React repo to RN 2018-04-07 23:23:33 -07:00
Sample Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Settings Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Share Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Storage Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
StyleSheet Downgrade ES6 import to ES5 compat module.exports 2018-04-05 06:36:53 -07:00
SurfaceBackedComponent Update license headers for MIT license 2018-02-16 18:31:53 -08:00
SurfaceHostingComponent Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Text Fix bug with <InputAccessoryView> safe area conformance 2018-04-04 16:47:16 -07:00
Types RN: Flow Type for `PressEvent` 2018-02-25 23:27:00 -08:00
Utilities Don't truncate in the middle of an emoji 2018-03-12 12:33:54 -07:00
Vibration Fix ESLint warnings using 'yarn lint --fix' 2018-02-22 07:23:17 -08:00
WebSocket Revert "Remove Platform check from WebSocket module" 2018-04-08 18:15:53 -07:00
Wrapper Update additional license headers 2018-03-08 12:10:14 -08:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Fix "function statements" in strict mode builds 2018-03-28 10:12:41 -07:00
react-native Update license headers for MIT license 2018-02-16 18:31:53 -08:00
vendor Update license headers for MIT license 2018-02-16 18:31:53 -08:00
.npmignore npmignore: ignore tests and fixtures 2018-02-27 08:42:14 -08:00
Promise.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
UTFSequence.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
promiseRejectionIsError.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00