status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/React/Modules
History
James Ide cb8b656a82 Only handle accessibility notifications from the correct RCTAccessibilityManager 
Summary: When you reload and create a new bridge, one of the things that happens during setup is that the RCTAccessibilityManager fires a notification. The old bridge would receive this notification from the new bridge's RCTAccessibilityManager, which we don't want, especially because the two are running on different shadow queues.

I believe this led to a gnarly crash in NSConcreteTextStorage because RCTMeasure in RCTShadowText.m was getting called for the old RCTText (getting destroyed) from a notification fired from the new shadow queue. The fix is for the UIManager to handle notifications only from its bridge's RCTAccessibilityManager. See #2001 for the kinds of crashes we were seeing.
Closes https://github.com/facebook/react-native/pull/3279

Reviewed By: @​svcscm

Differential Revision: D2521652

Pulled By: @nicklockwood

fb-gh-sync-id: a4ffe3ef8304667727e573e2a2e8b716e1d2f3e1
 		2015-10-08 04:00:41 -07:00
..
RCTAccessibilityManager.h Add Voice Over related change to AccessibilityManager. 2015-10-01 18:19:24 -07:00
RCTAccessibilityManager.m Add Voice Over related change to AccessibilityManager. 2015-10-01 18:19:24 -07:00
RCTAlertManager.h Remove an existing UIAlertViews when invalidating the RCTAlertManager 2015-09-18 08:45:27 -07:00
RCTAlertManager.m App Extension support 2015-09-22 10:46:26 -07:00
RCTAppState.h [ReactNative] s/ReactKit/React/g 2015-03-26 02:42:24 -08:00
RCTAppState.m revert D2372548 to fix initial app state issue 2015-09-25 13:25:26 -07:00
RCTAsyncLocalStorage.h Remove isValid from RCTInvalidating 2015-08-14 01:57:18 -08:00
RCTAsyncLocalStorage.m Ran Convert > To Modern Objective C Syntax 2015-08-25 01:08:49 -08:00
RCTDevLoadingView.h [RCTDevLoadingView] Add ability to disable during development. 2015-09-04 03:46:06 -08:00
RCTDevLoadingView.m [RCTDevLoadingView] Add ability to disable during development. 2015-09-04 03:46:06 -08:00
RCTDevMenu.h Added toggle items to dev menu 2015-09-14 09:40:33 -07:00
RCTDevMenu.m App Extension support 2015-09-22 10:46:26 -07:00
RCTExceptionsManager.h Finish up the work to send through the error cookie 2015-09-17 18:15:27 -07:00
RCTExceptionsManager.m Finish up the work to send through the error cookie 2015-09-17 18:15:27 -07:00
RCTPointAnnotation.h [MapView] Support for annotation callouts, annotation press, callout presses and pin animation 2015-06-25 09:15:21 -08:00
RCTPointAnnotation.m [MapView] Support for annotation callouts, annotation press, callout presses and pin animation 2015-06-25 09:15:21 -08:00
RCTRedBox.h Converted RCTRedBox to a bridge module 2015-08-21 02:53:55 -07:00
RCTRedBox.m Log column number in RCTRedBox messages 2015-09-29 09:22:14 -07:00
RCTSourceCode.h [ReactNative] s/ReactKit/React/g 2015-03-26 02:42:24 -08:00
RCTSourceCode.m [React Native] Bring back .sourceURL 2015-09-02 14:12:48 -08:00
RCTStatusBarManager.h Removed deprecated RCT_EXPORT + code paths 2015-06-05 09:58:25 -08:00
RCTStatusBarManager.m App Extension support 2015-09-22 10:46:26 -07:00
RCTTiming.h [ReactNative] Use a single DisplayLink held by the bridge 2015-04-15 07:07:48 -08:00
RCTTiming.m Pause JS DisplayLink if nothing to process. 2015-09-29 09:22:10 -07:00
RCTUIManager.h Add doc comment for mainScrollView 2015-08-21 04:00:03 -07:00
RCTUIManager.m Only handle accessibility notifications from the correct RCTAccessibilityManager 2015-10-08 04:00:41 -07:00