mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
edbb48c67a
Summary:
…th RCTSharedApplication()
Thanks for submitting a PR! Please read these instructions carefully:
- [ ] Explain the **motivation** for making this change.
Using React Native latest version with Cocoapods 1.2.0 causes the following error inside iOS app extensions
> /react-native/React/Modules/RCTAccessibilityManager.m:67:70: ‘sharedApplication’ is unavailable: not available on iOS (App Extension) — Use view controller based solutions where appropriate instead.
Moving the use of [UIApplication sharedApplication] to RCTSharedApplication() which is safe on app extension
- [ ] Provide a **test plan** demonstrating that the code is solid.
I am not sure how to test such that all the features which touch the modified code are tested.
- [ ] Match the **code formatting** of the rest of the codebase.
- [ ] Target the `master` branch, NOT a "stable" branch.
What existing problem does the pull request solve?
Using React Native latest v
Closes https://github.com/facebook/react-native/pull/13227
Differential Revision: D4816338
Pulled By: javache
fbshipit-source-id: e3e3c77882990ad1817b0b633521cff52571ecd0
71 lines
2.0 KiB
Objective-C
71 lines
2.0 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import <UIKit/UIKit.h>
|
|
#import <XCTest/XCTest.h>
|
|
|
|
#import <React/RCTLog.h>
|
|
#import <React/RCTRootView.h>
|
|
|
|
#define TIMEOUT_SECONDS 600
|
|
#define TEXT_TO_LOOK_FOR @"Welcome to React Native!"
|
|
|
|
@interface HelloWorldTests : XCTestCase
|
|
|
|
@end
|
|
|
|
@implementation HelloWorldTests
|
|
|
|
- (BOOL)findSubviewInView:(UIView *)view matching:(BOOL(^)(UIView *view))test
|
|
{
|
|
if (test(view)) {
|
|
return YES;
|
|
}
|
|
for (UIView *subview in [view subviews]) {
|
|
if ([self findSubviewInView:subview matching:test]) {
|
|
return YES;
|
|
}
|
|
}
|
|
return NO;
|
|
}
|
|
|
|
- (void)testRendersWelcomeScreen
|
|
{
|
|
UIViewController *vc = [[[RCTSharedApplication() delegate] window] rootViewController];
|
|
NSDate *date = [NSDate dateWithTimeIntervalSinceNow:TIMEOUT_SECONDS];
|
|
BOOL foundElement = NO;
|
|
|
|
__block NSString *redboxError = nil;
|
|
RCTSetLogFunction(^(RCTLogLevel level, RCTLogSource source, NSString *fileName, NSNumber *lineNumber, NSString *message) {
|
|
if (level >= RCTLogLevelError) {
|
|
redboxError = message;
|
|
}
|
|
});
|
|
|
|
while ([date timeIntervalSinceNow] > 0 && !foundElement && !redboxError) {
|
|
[[NSRunLoop mainRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
|
|
[[NSRunLoop mainRunLoop] runMode:NSRunLoopCommonModes beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
|
|
|
|
foundElement = [self findSubviewInView:vc.view matching:^BOOL(UIView *view) {
|
|
if ([view.accessibilityLabel isEqualToString:TEXT_TO_LOOK_FOR]) {
|
|
return YES;
|
|
}
|
|
return NO;
|
|
}];
|
|
}
|
|
|
|
RCTSetLogFunction(RCTDefaultLogFunction);
|
|
|
|
XCTAssertNil(redboxError, @"RedBox error: %@", redboxError);
|
|
XCTAssertTrue(foundElement, @"Couldn't find element with text '%@' in %d seconds", TEXT_TO_LOOK_FOR, TIMEOUT_SECONDS);
|
|
}
|
|
|
|
|
|
@end
|