status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Ben Roth 7fab093fc8 Fix crash when trying to load photo library assets with nil image url 
Summary:
This avoids a crash when we try to load a PHAsset with nil image url. Specifically, the following condition evaluates to true when `imageURL` is nil:

```objc
if ([imageURL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame) {
    assetID = [imageURL absoluteString];
    results = [PHAsset fetchAssetsWithALAssetURLs:@[imageURL] options:nil];
}
```

The crash will be "attempt to insert nil object from objects[0]" when we build the `@[imageURL]` array literal.

We've seen this emerge as a very common crash among Expo users, so I wanted to at least provide a clear error message instead of terminating the app.

Load an image from the photo library with a nil request url.
Closes https://github.com/facebook/react-native/pull/15952

Differential Revision: D5835219

Pulled By: ericnakagawa

fbshipit-source-id: 7be00a15e674a0905cf5c27c526ce9085d1b308f
 		2017-09-14 12:02:27 -07:00
..
ART Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
ActionSheetIOS Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Alert support null titles in AlertIOS 2017-09-11 16:08:03 -07:00
Animated Migrate tests away from "jsdom" environment 2017-09-11 09:49:11 -07:00
AppState Avoid race condition for AppState.currentState 2017-08-18 13:14:59 -07:00
BatchedBridge Reverting changes to MessageQueue 2017-09-07 14:30:59 -07:00
Blob @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
BugReporting Patch up for future React Sync 2017-02-08 14:50:43 -08:00
CameraRoll Fix crash when trying to load photo library assets with nil image url 2017-09-14 12:02:27 -07:00
Components Add Example for TouchableOpacity.js 2017-09-12 20:32:07 -07:00
Core Add missing delete to requestIdleCallback 2017-09-11 18:15:49 -07:00
EventEmitter Turn on Flow for EventEmitter 2017-08-30 11:52:28 -07:00
Experimental @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Geolocation @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Image Fix build errors exposed by building against clang 5.0 2017-09-14 00:35:02 -07:00
Inspector @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Interaction Reverting changes to MessageQueue 2017-09-07 14:30:59 -07:00
JSInspector Add Network agent 2016-11-02 12:29:15 -07:00
LayoutAnimation @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Linking fix flow warning and typo 2017-09-08 14:46:14 -07:00
LinkingIOS Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Lists Allow data lists to include 0 or '' (falsey items) 2017-09-13 17:33:03 -07:00
Modal Upgrade fbsource/xplat/js to Flow v0.53.0 2017-08-17 18:45:01 -07:00
NativeAnimation Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Network Migrate tests away from "jsdom" environment 2017-09-11 09:49:11 -07:00
Performance Gate more code with if (__DEV__) { } 2017-08-14 07:19:00 -07:00
PermissionsAndroid Update documentation for PermissionsAndroid 2017-08-16 15:01:51 -07:00
PushNotificationIOS Fix flowtype errors for PushNotificationIOS 2017-08-14 12:03:18 -07:00
RCTTest Increase RCTTestRunner timeouts 2017-08-25 10:00:39 -07:00
ReactNative @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Renderer Fix React Native open source 2017-08-29 15:01:05 -07:00
Sample Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Settings Fix infinite recursion in RCTSettingsManager init 2017-08-09 09:39:40 -07:00
Share Fix error in flow types 2017-09-12 05:50:26 -07:00
Storage correctly order ASyncStorage 2017-02-21 15:18:40 -08:00
StyleSheet Fix stylesheet registery 2017-08-23 08:54:39 -07:00
Text Proper support of the accessibilityLabel for <Text> components on iOS 2017-09-12 12:53:59 -07:00
Utilities @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Vibration fix and enrich Vibration docs 2017-08-23 20:45:45 -07:00
WebSocket @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Use proper script way to clone Emoji files from www 2017-08-21 16:29:39 -07:00
react-native Add Android React Native Checkbox 2017-08-25 10:30:54 -07:00
vendor @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
.eslintrc Disallow trailing commas in react-native-github 2017-08-17 16:20:04 -07:00
Promise.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
promiseRejectionIsError.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00