mirror of
https://github.com/status-im/react-native.git
synced 2025-01-13 11:05:21 +00:00
099b28006b
Summary: We are removing `reactBridgeDidFinishTransaction`. Why? * It is a performance drain. Supporting this requires dispatching main-thread block on every single transaction complete; * It has "too broad" non-conceptual semantic which encouraged using this as a "band-aid solution" for poorly designed components; * It is conceptually incompatible with new approaches that we are trying to implement to optimize the render layer; * It was deprecated for very long time. This diff replaces usage of `reactBridgeDidFinishTransaction` with `uiManagerDidPerformMounting` which has very similar semantic except that fact that `uiManagerDidPerformMounting` is called asynchronously on the next run loop tick. And this should be okay because new React partial rendering does not guarantee synchronous execution anyways. Reviewed By: mmmulani Differential Revision: D6549217 fbshipit-source-id: 2649e943e82e6fbe02c7678583a97db3f5800201
86 lines
2.3 KiB
Objective-C
86 lines
2.3 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTNavigatorManager.h"
|
|
|
|
#import "RCTBridge.h"
|
|
#import "RCTConvert.h"
|
|
#import "RCTNavigator.h"
|
|
#import "RCTUIManager.h"
|
|
#import "RCTUIManagerObserverCoordinator.h"
|
|
#import "UIView+React.h"
|
|
|
|
@interface RCTNavigatorManager () <RCTUIManagerObserver>
|
|
|
|
@end
|
|
|
|
@implementation RCTNavigatorManager
|
|
{
|
|
// The main thread only.
|
|
NSHashTable<RCTNavigator *> *_viewRegistry;
|
|
}
|
|
|
|
- (void)setBridge:(RCTBridge *)bridge
|
|
{
|
|
[super setBridge:bridge];
|
|
|
|
[self.bridge.uiManager.observerCoordinator addObserver:self];
|
|
}
|
|
|
|
- (void)invalidate
|
|
{
|
|
[self.bridge.uiManager.observerCoordinator removeObserver:self];
|
|
}
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (UIView *)view
|
|
{
|
|
if (!_viewRegistry) {
|
|
_viewRegistry = [NSHashTable hashTableWithOptions:NSPointerFunctionsWeakMemory];
|
|
}
|
|
|
|
RCTNavigator *view = [[RCTNavigator alloc] initWithBridge:self.bridge];
|
|
[_viewRegistry addObject:view];
|
|
return view;
|
|
}
|
|
|
|
RCT_EXPORT_VIEW_PROPERTY(requestedTopOfStack, NSInteger)
|
|
RCT_EXPORT_VIEW_PROPERTY(onNavigationProgress, RCTDirectEventBlock)
|
|
RCT_EXPORT_VIEW_PROPERTY(onNavigationComplete, RCTBubblingEventBlock)
|
|
RCT_EXPORT_VIEW_PROPERTY(interactivePopGestureEnabled, BOOL)
|
|
|
|
RCT_EXPORT_METHOD(requestSchedulingJavaScriptNavigation:(nonnull NSNumber *)reactTag
|
|
callback:(RCTResponseSenderBlock)callback)
|
|
{
|
|
[self.bridge.uiManager addUIBlock:
|
|
^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTNavigator *> *viewRegistry){
|
|
RCTNavigator *navigator = viewRegistry[reactTag];
|
|
if ([navigator isKindOfClass:[RCTNavigator class]]) {
|
|
BOOL wasAcquired = [navigator requestSchedulingJavaScriptNavigation];
|
|
callback(@[@(wasAcquired)]);
|
|
} else {
|
|
RCTLogError(@"Cannot set lock: %@ (tag #%@) is not an RCTNavigator", navigator, reactTag);
|
|
}
|
|
}];
|
|
}
|
|
|
|
#pragma mark - RCTUIManagerObserver
|
|
|
|
- (void)uiManagerDidPerformMounting:(__unused RCTUIManager *)manager
|
|
{
|
|
RCTExecuteOnMainQueue(^{
|
|
for (RCTNavigator *view in self->_viewRegistry) {
|
|
[view uiManagerDidPerformMounting];
|
|
}
|
|
});
|
|
}
|
|
|
|
@end
|