674e74a963
Summary: Previously, every node would be clipped by its own boundaries. This made sense, because a) RCTView cannot draw outside of its bounds, so clipping is harmless b) all other node types were not allowed to control overflow behavior, and for them overflow was implicitly set to hidden, which means it should clip. This diff changes the logic so that overflow can be set on any node (image, text, view etc). The change has an important implication that make the diff a little trickier that it could be: AbstractDrawCommand clipping logic needs to be relaxed. Previously, clip bounds were *always* intersected with node bounds, which means that clip rect was always within node rect. This is no longer true, and thus shouldClip() logic needs to be modified. Because of the above, RCTText no longer needs to artificially clip bounds against layout width/height. Note: RCTImage is still not working with overflow: visible correctly (it still always clips). This is fixed in a follow up diff. Reviewed By: ahmedre Differential Revision: D2867849 |
||
|---|---|---|
| .. | ||
| libs | ||
| src | ||
| .npmignore | ||
| DEFS | ||
| DevExperience.md | ||
| README.md | ||
| build.gradle | ||
| gradle.properties | ||
| release.gradle | ||
README.md
Building React Native for Android
See the docs on the website.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.