80f7891287
Summary:
@public
This is follow up for D8601600 and D8247652 (the last one has detailed explanation of the problem).
From this commit I propose that we have to follow simple rule:
If some prop has a default value which differs from the default value of its type, we have to specify it as {<value>} in .h file and explicitly in .m file, for all other props the default value must not be specified explicitly (in .h files it must be specified as {}).
The reason is that we have to embrase those cases and establish behaviour: if we change the default value in .h file, it always means that we have to change the value in .cpp file too.
Reviewed By: fkgozali
Differential Revision: D8601776
fbshipit-source-id: 3379aace4e2d72febb2b942a3da1cb24decf54be
|
||
|---|---|---|
| .. | ||
| tests | ||
| BUCK | ||
| ScrollViewComponentDescriptor.h | ||
| ScrollViewEventEmitter.cpp | ||
| ScrollViewEventEmitter.h | ||
| ScrollViewLocalData.cpp | ||
| ScrollViewLocalData.h | ||
| ScrollViewProps.cpp | ||
| ScrollViewProps.h | ||
| ScrollViewShadowNode.cpp | ||
| ScrollViewShadowNode.h | ||
| conversions.h | ||
| primitives.h | ||