mirror of
https://github.com/status-im/react-native.git
synced 2025-01-16 12:34:17 +00:00
c858420b2d
Summary: This diff attempts to fix a number of iOS native animation bugs related to improper node invalidation and a race with view creation. The major issues were presented in #9120 as problems 3 and 3b, but I'll recap here: The invalidation model we use is overly complicated and incomplete. The proper combination of `_needsUpdate` and `_hasUpdated` will result in nodes values being recomputed. However, we do not invalidate nodes in all the places we should, e.g. if we create a new view and attach it to an existing value node (see example in #9120). This diff chooses to remove the `_hasUpdated` flag, and simply relies on the `_needsUpdate` flag to mark a node as dirty. We mark nodes as dirty when they are: - created - updated - attached to new parents - detached from old parents - attached to a view Calling `updateNodeIfNecessary` will, if necessary, compute all invalidated parent values before recomputing the node value. It will then apply the update, and mark the no Closes https://github.com/facebook/react-native/pull/10663 Differential Revision: D4120301 Pulled By: mkonicek fbshipit-source-id: e247afcb5d8c15999b8328c664b9f7e764d76a75
67 lines
1.6 KiB
Objective-C
67 lines
1.6 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTViewPropertyMapper.h"
|
|
|
|
#import <UIKit/UIKit.h>
|
|
|
|
#import <React/RCTBridge.h>
|
|
#import <React/RCTConvert.h>
|
|
#import <React/RCTUIManager.h>
|
|
|
|
#import "RCTNativeAnimatedModule.h"
|
|
|
|
@interface RCTViewPropertyMapper ()
|
|
|
|
@property (nonatomic, weak) UIView *cachedView;
|
|
@property (nonatomic, weak) RCTUIManager *uiManager;
|
|
|
|
@end
|
|
|
|
@implementation RCTViewPropertyMapper
|
|
|
|
- (instancetype)initWithViewTag:(NSNumber *)viewTag
|
|
uiManager:(RCTUIManager *)uiManager
|
|
{
|
|
if ((self = [super init])) {
|
|
_uiManager = uiManager;
|
|
_viewTag = viewTag;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
RCT_NOT_IMPLEMENTED(- (instancetype)init)
|
|
|
|
- (void)updateViewWithDictionary:(NSDictionary<NSString *, NSObject *> *)properties
|
|
{
|
|
// cache the view for perf reasons (avoid constant lookups)
|
|
UIView *view = _cachedView = _cachedView ?: [self.uiManager viewForReactTag:_viewTag];
|
|
if (!view) {
|
|
RCTLogError(@"No view to update.");
|
|
return;
|
|
}
|
|
|
|
if (!properties.count) {
|
|
return;
|
|
}
|
|
|
|
NSNumber *opacity = [RCTConvert NSNumber:properties[@"opacity"]];
|
|
if (opacity) {
|
|
view.alpha = opacity.floatValue;
|
|
}
|
|
|
|
NSObject *transform = properties[@"transform"];
|
|
if ([transform isKindOfClass:[NSValue class]]) {
|
|
view.layer.allowsEdgeAntialiasing = YES;
|
|
view.layer.transform = ((NSValue *)transform).CATransform3DValue;
|
|
}
|
|
}
|
|
|
|
@end
|