status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/React/Base
History
Dan Caspi 42d14bef04 Enforcing semi-colon consistency between dev and release modes when calling RCTLog* 
Summary:
The various RCTLog macros (`RCTLogWarn`, `RCTLogError`, etc..) are based on the `_RCTLog` macro, which, in its expanded form, has a semi-colon in DEV mode (i.e., when `RCTLOG_ENABLED` is set to 1), and doesn't have one when `RCTLOG_ENABLED` is set to 0.
This could lead to a situation where code will compile in DEV but will fail to compile for prod.
Fixing this by removing the semicolon from the DEV version (as should).

Reviewed By: javache

Differential Revision: D4189133

fbshipit-source-id: 54cb4e2c96d1e48d9df88464aa58b13af432c2bd
 		2016-11-16 07:28:32 -08:00
..
RCTAssert.h Display JS exceptions and stacks in a red box. 2016-06-30 19:43:28 -07:00
RCTAssert.m Display JS exceptions and stacks in a red box. 2016-06-30 19:43:28 -07:00
RCTBatchedBridge.m Show packager progress in UI 2016-10-13 11:43:41 -07:00
RCTBridge+Private.h Move batchedbridge start out of init 2016-09-26 16:14:11 -07:00
RCTBridge.h Add support for new ios bridge to FBReactBridgeJSExecutor 2016-09-28 14:13:55 -07:00
RCTBridge.m Add support for new ios bridge to FBReactBridgeJSExecutor 2016-09-28 14:13:55 -07:00
RCTBridgeDelegate.h Show packager progress in UI 2016-10-13 11:43:41 -07:00
RCTBridgeMethod.h Support sync method calls in the objc bridge 2016-09-05 07:44:00 -07:00
RCTBridgeModule.h Standardize Error objects for Promises 2016-01-19 12:20:37 -08:00
RCTBundleURLProvider.h allow fetching any resource under js folder via packager 2016-10-20 11:43:44 -07:00
RCTBundleURLProvider.m allow fetching any resource under js folder via packager 2016-10-20 11:43:44 -07:00
RCTConvert.h rename CSSWrapType to shorter CSSWrap matching java and csharp 2016-11-14 03:28:38 -08:00
RCTConvert.m rename CSSWrapType to shorter CSSWrap matching java and csharp 2016-11-14 03:28:38 -08:00
RCTDefines.h Add RCT_PROFILE define 2016-06-13 04:28:38 -07:00
RCTDisplayLink.h Pull CADisplayLink into a separate file 2016-03-29 19:53:20 -07:00
RCTDisplayLink.m Remove last arg from RCTProfileEnd, make macro's function-like 2016-09-05 11:13:33 -07:00
RCTErrorCustomizer.h Add ability to customize error messages and stacks within the iOS redbox 2016-07-18 11:28:36 -07:00
RCTErrorInfo.h Add ability to customize error messages and stacks within the iOS redbox 2016-07-18 11:28:36 -07:00
RCTErrorInfo.m Add ability to customize error messages and stacks within the iOS redbox 2016-07-18 11:28:36 -07:00
RCTEventDispatcher.h Add support for native animated events on iOS 2016-11-01 03:58:53 -07:00
RCTEventDispatcher.m Add support for native animated events on iOS 2016-11-01 03:58:53 -07:00
RCTFrameUpdate.h Pause JS DisplayLink if nothing to process. 2015-09-29 09:22:10 -07:00
RCTFrameUpdate.m Ran Convert > To Modern Objective C Syntax 2015-08-25 01:08:49 -08:00
RCTImageSource.h Remove deprecated RCTImageSource method 2016-08-23 11:28:42 -07:00
RCTImageSource.m Support bundle argument for image loading 2016-08-31 17:43:49 -07:00
RCTInvalidating.h Remove isValid from RCTInvalidating 2015-08-14 01:57:18 -08:00
RCTJSStackFrame.h Class for JS stack frames instead of dictionaries 2016-07-11 06:13:32 -07:00
RCTJSStackFrame.m Fix crash in RCTJSStackFrame 2016-08-26 09:58:47 -07:00
RCTJavaScriptExecutor.h Add MessageQueue method for executing function and returning its result 2016-07-18 07:13:32 -07:00
RCTJavaScriptLoader.h Bytecode Exposure Logging 2016-11-14 07:58:31 -08:00
RCTJavaScriptLoader.m Bytecode Exposure Logging 2016-11-14 07:58:31 -08:00
RCTKeyCommands.h Add Shortcut "Double R" to Reload JS in iOS 2016-06-01 03:43:27 -07:00
RCTKeyCommands.m Cleanup warnings 2016-07-12 05:59:12 -07:00
RCTLog.h Enforcing semi-colon consistency between dev and release modes when calling RCTLog* 2016-11-16 07:28:32 -08:00
RCTLog.mm Cleanup display of C++ stack frames in redbox 2016-11-14 04:59:13 -08:00
RCTModuleData.h Replaced isMainThread checks with a proper test for main queue 2016-06-06 07:58:36 -07:00
RCTModuleData.mm Modules export constants if any superclass exports them (2nd try) 2016-10-31 04:58:50 -07:00
RCTModuleMethod.h Implement Android's dispatchViewManagerCommand interface on iOS 2016-01-06 05:58:37 -08:00
RCTModuleMethod.m Remove last arg from RCTProfileEnd, make macro's function-like 2016-09-05 11:13:33 -07:00
RCTMultipartDataTask.h Add multipart response download task (2nd edition) 2016-10-11 12:28:42 -07:00
RCTMultipartDataTask.m Fix some warnings in React.xcodeproj 2016-10-27 04:29:01 -07:00
RCTMultipartStreamReader.h Add multipart response stream reader 2016-10-03 18:13:36 -07:00
RCTMultipartStreamReader.m Add multipart response download task (2nd edition) 2016-10-11 12:28:42 -07:00
RCTNullability.h Replaced RegExp method parser with recursive descent 2015-12-10 10:12:29 -08:00
RCTParserUtils.h Replaced RegExp method parser with recursive descent 2015-12-10 10:12:29 -08:00
RCTParserUtils.m Replaced RegExp method parser with recursive descent 2015-12-10 10:12:29 -08:00
RCTPerformanceLogger.h Refactor measuring native requires 2016-09-09 15:28:44 -07:00
RCTPerformanceLogger.m Refactor measuring native requires 2016-09-09 15:28:44 -07:00
RCTPlatform.h Move Platform constants to RCTPlatform 2016-10-27 04:29:00 -07:00
RCTPlatform.m Move Platform constants to RCTPlatform 2016-10-27 04:29:00 -07:00
RCTRootView.h Don't receive touches in RCTRootView 2016-11-03 09:58:48 -07:00
RCTRootView.m Don't receive touches in RCTRootView 2016-11-03 09:58:48 -07:00
RCTRootViewDelegate.h Prevent RCTRootView delegate call 2015-11-13 08:28:28 -08:00
RCTRootViewInternal.h Introduction of RCTRootViewDelegate 2015-10-26 15:41:36 -07:00
RCTTouchEvent.h Set viewTag for RCTTouchEvent to avoid EventID conflict 2016-09-16 16:13:47 -07:00
RCTTouchEvent.m Set viewTag for RCTTouchEvent to avoid EventID conflict 2016-09-16 16:13:47 -07:00
RCTTouchHandler.h API for cancelling RCTTouchHandler 2016-01-21 13:46:52 -08:00
RCTTouchHandler.m Set viewTag for RCTTouchEvent to avoid EventID conflict 2016-09-16 16:13:47 -07:00
RCTURLRequestDelegate.h Refactored networking logic out into RCTDownloadTask 2015-07-23 04:00:31 -08:00
RCTURLRequestHandler.h [ReactNative] Refactor RCTDataManager to support pluggable data source modules (RCTURLRequestHandlers) 2015-06-09 12:27:06 -08:00
RCTUtils.h Apple TV support 1: existing Objective C code should compile for tvOS 2016-09-27 06:28:33 -07:00
RCTUtils.m Allow serializing underlying NSError objects, closes #10506 2016-10-26 01:43:39 -07:00
RCTWebSocketProxy.h Enable persistent socket between packager and bridge (1/N). 2016-02-16 23:05:36 -08:00
RCTWebSocketProxyDelegate.h Enable persistent socket between packager and bridge (1/N). 2016-02-16 23:05:36 -08:00