mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
5aa1fb3ff3
Summary: `Canvas.clipPath` isn't supported with hardware acceleration in APIs below 18. The rounded border rendering logic for Android relies on this method. Therefore, rounded borders do not render correctly on such devices. **Screenshot of Nexus 5 running API 17 (Before these changes):** https://pxl.cl/9rsf **The fix**: If the API version is less than 18 and we're rendering rounded borders, I disable hardware acceleration. Otherwise, I enable it. I'm going to check to see if this has perf regressions by running a CT-Scan. With this change, rounded borders render correctly on Android devices running versions of Android between Honeycomb to JellyBean MR2. **Screenshot of Nexus 5 running API 17 (After these changes):** https://pxl.cl/9rrk Reviewed By: xiphirx Differential Revision: D6153087 fbshipit-source-id: 16e35be096051ac817c8b8bcdd132ecff3b4b167
Building React Native for Android
See the docs on the website.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.