mirror of
https://github.com/status-im/react-native.git
synced 2025-01-17 13:01:13 +00:00
9ae3714f4b
Summary:**Problem**: As seen in https://github.com/facebook/react-native/issues/5820, many devs are confused by the fact that the offline bundle is not generated when running against the simulator, even when running in the "Release" configuration which is supposed to mimic "production" scenarios. This pull request is a small change that fixes https://github.com/facebook/react-native/issues/5820 by updating the `react-native-xcode.sh` shell script to still generate the ofline bundle during Release configuration. It also updates `AppDelegate.m` to better document this behaviour in the comments so as to avoid any surprises. **Test plan**: This is a simple change, the two tests done were 1. In a new React Native project, verify that an offline build is not generated when running against the simulator in "Debug" configuration as per normal. 2. Change to a "Release" configuration via Product > Scheme > Edit Scheme in XCode, then verify that the project runs with the offline build generated. ![screen shot 2016-02 Closes https://github.com/facebook/react-native/pull/6119 Differential Revision: D2970755 Pulled By: javache fb-gh-sync-id: 64f658512869c73aa19286ca1e3dc6e31b5ac617 shipit-source-id: 64f658512869c73aa19286ca1e3dc6e31b5ac617
60 lines
2.1 KiB
Objective-C
60 lines
2.1 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "AppDelegate.h"
|
|
|
|
#import "RCTRootView.h"
|
|
|
|
@implementation AppDelegate
|
|
|
|
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
|
|
{
|
|
NSURL *jsCodeLocation;
|
|
|
|
/**
|
|
* Loading JavaScript code - uncomment the one you want.
|
|
*
|
|
* OPTION 1
|
|
* Load from development server. Start the server from the repository root:
|
|
*
|
|
* $ npm start
|
|
*
|
|
* To run on device, change `localhost` to the IP address of your computer
|
|
* (you can get this by typing `ifconfig` into the terminal and selecting the
|
|
* `inet` value under `en0:`) and make sure your computer and iOS device are
|
|
* on the same Wi-Fi network.
|
|
*/
|
|
|
|
jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle?platform=ios&dev=true"];
|
|
|
|
/**
|
|
* OPTION 2
|
|
* Load from pre-bundled file on disk. The static bundle is automatically
|
|
* generated by the "Bundle React Native code and images" build step when
|
|
* running the project on an actual device or running the project on the
|
|
* simulator in the "Release" build configuration.
|
|
*/
|
|
|
|
// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
|
|
|
|
RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
|
|
moduleName:@"<%= name %>"
|
|
initialProperties:nil
|
|
launchOptions:launchOptions];
|
|
|
|
self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
|
|
UIViewController *rootViewController = [UIViewController new];
|
|
rootViewController.view = rootView;
|
|
self.window.rootViewController = rootViewController;
|
|
[self.window makeKeyAndVisible];
|
|
return YES;
|
|
}
|
|
|
|
@end
|