status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Components/Picker
History
Jake Dawkins 6234a5dfa2 Fix iOS Picker Item Colors 
Summary:
I want to resolve #11170 by passing the `color` prop from `PickerIOS.Item` to its implementation.

In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before.

I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.

![dec-01-2016 22-07-46](https://cloud.githubusercontent.com/assets/9259509/20821696/ae45d704-b812-11e6-9720-0045d6c0bcd4.gif)

The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:

![dec-01-2016 22-09-35](https://cloud.githubusercontent.com/assets/9259509/20821730/ee544f74-b812-11e6-9294-a1b45e78d9f7.gif)
Closes https://github.com/facebook/react-native/pull/11260

Differential Revision: D4272370

fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
 		2016-12-03 18:58:29 -08:00
..
Picker.js Clean unused import modules. 2016-10-16 11:13:40 -07:00
PickerAndroid.android.js RN: Stop Deep Linking `ReactChildren` 2016-10-14 18:59:10 -07:00
PickerAndroid.ios.js Add a cross-platform Picker 2016-01-29 03:59:54 -08:00
PickerIOS.android.js Removed exported constants for fixed-size views 2016-04-26 04:21:39 -07:00
PickerIOS.ios.js Fix iOS Picker Item Colors 2016-12-03 18:58:29 -08:00