mirror of https://github.com/status-im/react-native.git synced 2025-01-10 01:25:39 +00:00

History

Andy Street 58f86b2d91 Don't execute things that may throw in Bridge/JSCExecutor dtors

Summary:In testing, I've found that there's no good way to return stack traces to the server for exceptions that happen in dtor's. If the dtor is not marked nothrow(false), the exceptions are uncatchable (and bubble up as a std::abort without exception info) and if annotated properly, the program instead crashes trying to resume the stack, again a std::abort without exception info.

Instead, I created a separate destroy method that can be called (and protected via fbjni) to make the dtor's no longer execute code that may throw. Note that we don't really expect the code that was previously in ~JSCExecutor() to throw, but it was in production and we had absolutely no info to help debug it.

Reviewed By: mhorowitz

Differential Revision: D2989999

fb-gh-sync-id: 4cf9de5e0592fe6830a9903375363a78e1339a94
shipit-source-id: 4cf9de5e0592fe6830a9903375363a78e1339a94

2016-03-01 04:26:35 -08:00

libs

Add BUCK files

2016-01-22 16:20:13 +00:00

src

Don't execute things that may throw in Bridge/JSCExecutor dtors

2016-03-01 04:26:35 -08:00

.npmignore

Don't publish /ReactAndroid/build to npm, update version on master

2015-10-12 11:11:40 -07:00

build.gradle

Added ability to run Movies app with BUCK