status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Jake Dawkins 6234a5dfa2 Fix iOS Picker Item Colors 
Summary:
I want to resolve #11170 by passing the `color` prop from `PickerIOS.Item` to its implementation.

In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before.

I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.

![dec-01-2016 22-07-46](https://cloud.githubusercontent.com/assets/9259509/20821696/ae45d704-b812-11e6-9720-0045d6c0bcd4.gif)

The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:

![dec-01-2016 22-09-35](https://cloud.githubusercontent.com/assets/9259509/20821730/ee544f74-b812-11e6-9294-a1b45e78d9f7.gif)
Closes https://github.com/facebook/react-native/pull/11260

Differential Revision: D4272370

fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
 		2016-12-03 18:58:29 -08:00
..
ART RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
ActionSheetIOS Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
AdSupport Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
Alert fix typo in Alert.js 2016-10-14 08:13:55 -07:00
Animated Add more info link for warnedMissingNativeAnimated 2016-12-02 15:28:31 -08:00
AppState Remove deprecated APIs and modules 2016-10-11 07:43:52 -07:00
BatchedBridge Deploy v0.35.0 2016-11-14 20:45:17 -08:00
BugReporting RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
CameraRoll Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
Components Fix iOS Picker Item Colors 2016-12-03 18:58:29 -08:00
Core Cannot assign to read only property 'product' of object '#<WorkerNavi… 2016-11-22 07:28:34 -08:00
CustomComponents Typo 2016-11-28 03:43:32 -08:00
DebugComponentHierarchy Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
EventEmitter RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00
Experimental enable variable size slideoutView with swipeableListView 2016-11-14 11:58:58 -08:00
Geolocation Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
Image iOS: Fix an image loader crash 2016-12-01 21:28:33 -08:00
Inspector RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
Interaction Add missing backtick in PanResponder.js docs 2016-12-02 15:13:34 -08:00
JSInspector Add Network agent 2016-11-02 12:29:15 -07:00
LayoutAnimation Mention that LayoutAnimation has to be explicitly enabled on A… 2016-11-25 15:28:28 -08:00
Linking Auto-fix lint errors 2016-08-09 06:43:46 -07:00
LinkingIOS Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
Modal make Modal pass rootTag to AppContainer 2016-11-18 01:43:26 -08:00
NativeAnimation Fix NativeAnimation invalidation & races on iOS 2016-11-28 11:13:31 -08:00
NavigationExperimental Fix animation in fast navigation between scenes 2016-11-23 09:58:42 -08:00
Network Deploy v0.36.0 2016-11-28 10:13:31 -08:00
Performance RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
PermissionsAndroid Handle "Never Ask Again" in permissions and add requestMultiplePermissions 2016-11-24 22:43:28 -08:00
PushNotificationIOS Add missing closing brace in docs 2016-12-02 15:28:31 -08:00
RCTTest Fix imports in UIExplorerUnitTests 2016-11-24 09:58:31 -08:00
ReactNative Don't dismiss keyboard when tapping another text input 2016-11-25 05:43:30 -08:00
Renderer Add StyleSheet.setStyleAttributePreprocessor 2016-11-29 15:28:32 -08:00
Sample Update React Native minimum OS version to iOS8 2016-09-01 19:43:47 -07:00
Settings Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
Share Update Share.js. Fixed bad grammar 2016-11-23 11:28:29 -08:00
Storage Auto-fix lint errors 2016-08-09 06:43:46 -07:00
StyleSheet Add StyleSheet.setStyleAttributePreprocessor 2016-11-29 15:28:32 -08:00
Text Rename C api 2016-12-03 04:44:10 -08:00
Utilities Workaround native module dependency in Jest environment 2016-11-22 23:58:30 -08:00
Vibration Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
WebSocket Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
react-native RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00
vendor RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00
Promise.js Make onUnhandled safe for undefined errors 2016-08-02 07:58:28 -07:00
promiseRejectionIsError.js RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00