react-native

mirror of https://github.com/status-im/react-native.git synced 2025-01-16 12:34:17 +00:00

History

alekhurst 55ce19d84e Change gesture direction strings in NavigatorSceneConfigs

Summary:
I see there is a string matching inconsistency in  `Libraries/CustomComponents/Navigator/Navigator.js` and `Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js`, which caused a bug resulting in gestures not working for vertical SceneConfigs. This PR fixes the inconsistency, and the bug.

**Motivation for making this change**
When working with the navigator, I was using the `VerticalUpSwipeJump` Navigator SceneConfig. The gesture to pop to the previous scene (in this case `jumpBack`) was not working.

**How I tested?**
I changed these strings (as shown in this PR) and swiped down. After these changes, everything worked as expected.

**Example**
In `Libraries/CustomComponents/Navigator/Navigator.js`, we check for gesture direction strings `bottom-to-top` and `top-to-bottom` in multiple places, but nowhere do we ever check for `up-to-down` and `down-to-up`.

```
var isTravelVertical = gesture.direction === 'top-to-bottom' || gesture.direction === 'bottom-to-top';
var isTravelInverted =
Closes https://github.com/facebook/react-native/pull/11192

Differential Revision: D4392103

Pulled By: ericvicenti

fbshipit-source-id: fd80578031f94b1b409815481c82e481c7ff2f13

2017-01-09 01:43:33 -08:00

Navigation

Cleanup: Remove @typechecks

2016-10-12 19:28:42 -07:00

Navigator.js

Apple TV support 4: support for input (tvOS focus engine)

2016-12-19 06:28:40 -08:00

NavigatorBreadcrumbNavigationBar.js

Remove duplicated call from NavigatorSceneConfigs

2016-10-10 17:44:28 -07:00

NavigatorBreadcrumbNavigationBarStyles.android.js

Export per-platform NavigatorNavigationBarStyles for consistent styling