mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 09:35:48 +00:00
1d6d1189f0
Summary: public The image loader was previously returning on the main thread, which could lead to poor performance due to various call sites doing further image processing (resizing, cropping, etc.) directly in the completion block. This diff modifies the loader to return on a background thread (the same one used to load the image), and updates the call sites to dispatch to the explicit thread they need. Reviewed By: javache Differential Revision: D2549774 fb-gh-sync-id: fed73b7c163fdf67ff65bae72ab1986327e75815
57 lines
1.6 KiB
Objective-C
57 lines
1.6 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTXCAssetImageLoader.h"
|
|
|
|
#import <libkern/OSAtomic.h>
|
|
|
|
#import "RCTUtils.h"
|
|
|
|
@implementation RCTXCAssetImageLoader
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (BOOL)canLoadImageURL:(NSURL *)requestURL
|
|
{
|
|
return RCTIsXCAssetURL(requestURL);
|
|
}
|
|
|
|
- (RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL
|
|
size:(CGSize)size
|
|
scale:(CGFloat)scale
|
|
resizeMode:(UIViewContentMode)resizeMode
|
|
progressHandler:(RCTImageLoaderProgressBlock)progressHandler
|
|
completionHandler:(RCTImageLoaderCompletionBlock)completionHandler
|
|
{
|
|
__block volatile uint32_t cancelled = 0;
|
|
dispatch_async(dispatch_get_main_queue(), ^{
|
|
|
|
if (cancelled) {
|
|
return;
|
|
}
|
|
NSString *imageName = RCTBundlePathForURL(imageURL);
|
|
UIImage *image = [UIImage imageNamed:imageName];
|
|
if (image) {
|
|
if (progressHandler) {
|
|
progressHandler(1, 1);
|
|
}
|
|
completionHandler(nil, image);
|
|
} else {
|
|
NSString *message = [NSString stringWithFormat:@"Could not find image named %@", imageName];
|
|
completionHandler(RCTErrorWithMessage(message), nil);
|
|
}
|
|
});
|
|
|
|
return ^{
|
|
OSAtomicOr32Barrier(1, &cancelled);
|
|
};
|
|
}
|
|
|
|
@end
|