Martin Kralik 02b6e38bee better event emitting II: no deadlocks ... Summary:D3092867 / 1d3db4c5dc caused deadlock when chrome debugging was turned on, so it was reverted as D3128586 / 144dc30661. The reason: I was calling `[_bridge dispatchBlock:^{ [self flushEventsQueue]; } queue:RCTJSThread];` from main thread and expecting it will `dispatch_async` to another, since a held lock was being accessed the dispatched block and was released after the dispatch. Turns out `RCTWebSocketExecutor` (which is used when chrome debugger is turned on) executes all blocks dispatched this way to `RCTJSThread` synchronously on the main thread. This resulted in a deadlock. The "dispatched" block was trying to acquired lock which held by the same thread in the dispatching phase. A fix for this is pretty simple. We will release the lock before dispatching the block. However it's not super straightforward to see this won't introduce some race condition in a case with two threads where we would end up with events not being processed. My thinking why that shouldn't happen goes like this: We could get in a bad state if `flushEventsQueue` would run on JS thread while `sendEvent:` is running on MT. (I don't have a specific example how, maybe it's not possible. However when I show this case is safe we know we are good.) The way how locking is setup in this diff the only possible scenario where these two threads would execute in these methods concurrently is JS holding the lock and MT going to enqueue another block on JS thread (since that's outside of "locked" zone). But this scenarion can never happen, since if MT is about to enqueue the block on JS thread it means there cannot be a not yet fully executed block on JS thread. Therefore nothing bad can happen. So this diff brings back the reverted diff and adds to it the fix for the deadlock. Reviewed By: javache Differential Revision: D3130375 fb-gh-sync-id: 885a166f2f808551d7cd4e4eb98634d26afe6a11 fbshipit-source-id: 885a166f2f808551d7cd4e4eb98634d26afe6a11		2016-04-02 23:31:25 -07:00
..
Base	better event emitting II: no deadlocks	2016-04-02 23:31:25 -07:00
Executors	Append D3126321	2016-04-01 11:09:22 -07:00
Layout	Backed out changeset 14a8c290bb874ab3e954b45f6fb29d71d019adc2.	2016-03-16 08:53:25 -07:00
Modules	Prevent loading message from resetting simulator orientation on every reload.	2016-04-01 12:31:21 -07:00
Profiler	Add more performance logs and Systrace events for RAM and bridge startup	2016-04-01 07:25:38 -07:00
React.xcodeproj	Fix OSS project configuration	2016-03-30 03:12:27 -07:00
Views	limit fake scroll event emitting	2016-04-01 06:54:50 -07:00