react-native/Libraries
Christine Abernathy 12488da9cf Left nav shouldn't visible when moved to left
Summary: This issue shows up if you have a really long left nav item. When the navigator is pushed in iOS, the long nav item will be visible alongside the new nav item.

Steps to repro:
1/ Modify Examples/UIExplorer/Navigator/NavigationBarSample.js
2/ In NavigationBarRouteMapper.LeftButton, make the following change

    <Text style={[styles.navBarText, styles.navBarButtonText]}>
      Very Long Title {previousRoute.title}
    </Text>

3/ On iOS, get the UIExplorer project up and navigate to Navigator > Navbar Example > Next (top-right nav item) > Next

You should see the overlap.

<img width="592" alt="leftnavitem_issue" src="https://cloud.githubusercontent.com/assets/691109/11086934/b5b82e26-880a-11e5-9945-13901346a5c5.png">

With these changes the overlap is gone.
Closes https://github.com/facebook/react-native/pull/4067

Reviewed By: svcscm

Differential Revision: D2641934

Pulled By: ericvicenti

fb-gh-sync-id: 962536b97f77a3b7f176423aa11dc94f24f07332
2015-11-11 09:02:57 -08:00
..
ART Expose additional private modules 2015-11-05 03:35:18 -08:00
ActionSheetIOS Fixed display of alerts on top of modal window 2015-11-05 03:54:31 -08:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Fix breakages when upgrading to babel 6 2015-11-10 10:56:48 -08:00
AppRegistry [React Native] Provide a way to get a list of registered apps in AppRegistry 2015-08-07 11:05:25 -08:00
AppStateIOS revert D2372548 to fix initial app state issue 2015-09-25 13:25:26 -07:00
BatchedBridge Adding jest tests to groups rn 2015-08-31 17:35:47 -08:00
CameraRoll Improved and generalized image thumbnail decoding logic 2015-11-10 05:04:34 -08:00
Components Add keyboardAppearance prop to TextInput component. 2015-11-11 05:38:35 -08:00
CustomComponents Left nav shouldn't visible when moved to left 2015-11-11 09:02:57 -08:00
DebugComponentHierarchy [ReactNative] Send debug component ownership info in createView 2015-06-25 05:47:24 -08:00
Device
Devtools Use pre-bundled elements inspector 2015-10-29 11:21:32 -07:00
Fetch Add fetch's clone function to Request and Response prototypes 2015-10-30 10:57:33 -07:00
Geolocation Added lightweight generic annotations 2015-11-03 14:49:30 -08:00
Image Improved and generalized image thumbnail decoding logic 2015-11-10 05:04:34 -08:00
Inspector [react-native] enable react devtools from JavascriptCore 2015-07-23 17:14:09 -08:00
Interaction Make InteractionManager.runAfterInteractions() return a Promise 2015-11-09 20:14:26 -08:00
JavaScriptAppEngine Ensure exceptions from route generation are reported 2015-11-09 09:13:27 -08:00
LayoutAnimation [ReactNative] Remove POPAnimation 2015-08-20 22:24:28 -07:00
LinkingIOS Add note for iOS9 url scheme changes 2015-10-12 08:04:24 -07:00
Modal Make <Modal> visible by default 2015-10-30 17:09:27 -07:00
NativeApp [ReactNative] Add "RCTNativeAppEventEmitter" 2015-05-15 16:57:18 -08:00
Network Fix retain cyles in RCTNetworkTask when used with RCTFileRequestHandler and RCTDataRequestHandler 2015-11-04 07:16:26 -08:00
Picker Fixed PickerIOS onChange event 2015-09-08 03:34:33 -08:00
Portal [RN] add clarifying Android-only comment to Portal 2015-08-31 11:10:45 -08:00
PushNotificationIOS Add support for cancelAllLocalNotifications 2015-10-16 10:57:25 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest Provide log source to handler 2015-11-11 06:44:30 -08:00
RKBackendNode [ReactNative] clean lint in all of Libraries/ 2015-05-19 13:47:04 -08:00
ReactIOS Fixed: Move out setupDevtools call from renderApplication function 2015-11-05 08:50:29 -08:00
ReactNative Fix open source 2015-11-07 11:41:20 -08:00
Sample Remove invariant of Sample.ios.js that is not used 2015-05-26 18:25:00 -07:00
Settings Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Storage Fix AsyncStorage error multiplexing 2015-10-28 12:03:26 -07:00
StyleSheet Expose additional private modules 2015-11-05 03:35:18 -08:00
Text Add keyboardAppearance prop to TextInput component. 2015-11-11 05:38:35 -08:00
Utilities Fix reference to mustfix in RCTLog 2015-11-10 04:51:30 -08:00
Vibration Text highlighting on iOS 2015-07-24 08:41:58 -08:00
WebSocket Command line flags to start RN apps in web executor mode. 2015-11-06 14:53:28 -08:00
react-native Expose additional private modules 2015-11-05 03:35:18 -08:00
vendor Added support for #rgba and #rrggbbaa colors 2015-11-09 08:02:46 -08:00
Promise.js