status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Image
History
Nick Lockwood f827a513a1 Fixed double-callback for cached images 
Summary: public

A missing return statement in RCTImageLoader meant that cached images would be loaded twice - once from cache and again from the source.

This was mostly innocuous, causing only a slight perf regression due to the image cache being effectively disabled, however in some cases (such as RCTImageEditingManager.cropImage) it caused the success callback to fire twice, resulting in a crash.

Reviewed By: fkgozali

Differential Revision: D2684956

fb-gh-sync-id: 7580a6fbfe00a30807951803e04bfcdbee3bb80a
 		2015-11-23 04:20:28 -08:00
..
RCTImage.xcodeproj Added RCTDataRequestHandler 2015-10-19 09:07:06 -07:00
__tests__ Load assets from same folder as JS bundle 2015-11-05 12:53:26 -08:00
AssetRegistry.js [ReactNative] Teach flow how to deal with images 2015-08-26 18:26:09 -08:00
GlobalImageStub.js Removed references to isStatic from the codebase 2015-10-13 06:44:30 -07:00
Image.android.js Use requireNativeComponent everywhere. 2015-11-18 09:43:28 -08:00
Image.ios.js Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
ImageResizeMode.js [react_native] JS files from D2009265: Fix resizeMode for images 2015-04-21 12:04:32 -08:00
ImageSource.js Removed references to isStatic from the codebase 2015-10-13 06:44:30 -07:00
ImageStylePropTypes.js [ReactNative] Add overflow to the whitelisted Image props 2015-07-27 11:06:27 -08:00
RCTGIFImageDecoder.h Added RCTDataRequestHandler 2015-10-19 09:07:06 -07:00
RCTGIFImageDecoder.m Replaced RCTSparseArray with NSDictionary 2015-11-14 10:28:28 -08:00
RCTImageEditingManager.h [React Native] open source ImageEditingManager native module 2015-07-29 15:57:48 -08:00
RCTImageEditingManager.m [React Native] open source ImageEditingManager native module 2015-07-29 15:57:48 -08:00
RCTImageLoader.h Improved threading for image loader 2015-10-20 05:02:23 -07:00
RCTImageLoader.m Fixed double-callback for cached images 2015-11-23 04:20:28 -08:00
RCTImageStoreManager.h RTCImageStoreManager uses NSData instead of UIImage 2015-11-17 09:55:31 -08:00
RCTImageStoreManager.m Removed all calls to [UIImage imageWithData:] on a background thread 2015-11-20 05:17:33 -08:00
RCTImageUtils.h RTCImageStoreManager uses NSData instead of UIImage 2015-11-17 09:55:31 -08:00
RCTImageUtils.m Removed all calls to [UIImage imageWithData:] on a background thread 2015-11-20 05:17:33 -08:00
RCTImageView.h Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
RCTImageView.m Weak RCTBridge reference in RCTImageView 2015-11-17 09:14:30 -08:00
RCTImageViewManager.h Merged RCTNetworkImageView functionality into RCTStaticImage 2015-07-17 07:43:16 -08:00
RCTImageViewManager.m Added mechanism for directly mapping JS event handlers to blocks 2015-09-02 06:11:24 -08:00
RCTShadowVirtualImage.h Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
RCTShadowVirtualImage.m Improved threading for image loader 2015-10-20 05:02:23 -07:00
RCTVirtualImageManager.h Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
RCTVirtualImageManager.m Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
RCTXCAssetImageLoader.h Unify XCAsset handling logic 2015-10-12 04:15:27 -07:00
RCTXCAssetImageLoader.m Improved threading for image loader 2015-10-20 05:02:23 -07:00
RelativeImageStub.js [ReactNative] Teach flow how to deal with images 2015-08-26 18:26:09 -08:00
resolveAssetSource.js Load assets from same folder as JS bundle 2015-11-05 12:53:26 -08:00