status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-10 09:35:48 +00:00
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Christopher Chedeau 1491668b35 ColorPropTypes support for isRequired and more precise description 
Summary:
The previous implementation of ColorPropType was very hacky as it used `ReactPropTypes.oneOfType([colorValidator, ReactPropTypes.number])`. It turns out that oneOfType also accepts arbitrary functions instead of a type, but doesn't display any of the error message.

In this diff I properly implement isRequired (sadly we don't export `createChainableTypeChecker` in ReactPropTypes) and provide a lot more context that we have. I copy and pasted the way we displayed this context from the existing checkers.

**Test Plan**

When doing .isRequired and do not provide the value:

![simulator screen shot feb 1 2016 9 56 00 am](https://cloud.githubusercontent.com/assets/197597/12726239/61243f88-c8cb-11e5-889b-6594ffd85973.png)

When providing a bad value:

![simulator screen shot feb 1 2016 10 01 25 am](https://cloud.githubusercontent.com/assets/197597/12726244/6e80aa36-c8cb-11e5-9bd3-a8637de75496.png)
Closes https://github.com/facebook/react-native/pull/5671

Reviewed By: svcscm

Differential Revision: D2886760

Pulled By: vjeux

fb-gh-sync-id: d6be42b5768fca5463fe80fe4b144506d21b0832
2016-02-01 12:47:32 -08:00
..
ActionSheetIOS
ActionSheetIOS support for presentation from modal view controller
2016-01-12 03:14:35 -08:00
AdSupport
…
Animated
Reimplement color processing
2016-01-29 09:13:32 -08:00
AppRegistry
Decouple Module System from Native Calls
2015-12-08 16:03:37 -08:00
AppState
Tweak docs before releasing 0.19
2016-01-30 17:11:28 -08:00
AppStateIOS
Made Map & Set polyfills available globally
2016-01-20 08:27:38 -08:00
ART
Fixed ART background color
2016-01-08 15:42:32 -08:00
BatchedBridge
Implement Android's dispatchViewManagerCommand interface on iOS
2016-01-06 05:58:37 -08:00
CameraRoll
Tweak docs before releasing 0.19
2016-01-30 17:11:28 -08:00
Components
Add headers prop to Android WebViews
2016-02-01 10:06:35 -08:00
CustomComponents
Add a deprecatedPropType module to show deprecation warnings
2016-01-29 02:05:38 -08:00
DebugComponentHierarchy
Decouple Module System from Native Calls
2015-12-08 16:03:37 -08:00
Device
Decouple Module System from Native Calls
2015-12-08 16:03:37 -08:00
Devtools
Use pre-bundled elements inspector
2015-10-29 11:21:32 -07:00
Fetch
Add fetch's clone function to Request and Response prototypes
2015-10-30 10:57:33 -07:00
Geolocation
See issue #4886
2016-01-12 03:11:31 -08:00
Image
Fix CPU spike: should use UIGraphicsEndImageContext rather than UIGraphicsGetCurrentContext
2016-01-28 14:25:35 -08:00
Inspector
Fix warnings generated by Elements Inspector
2016-01-25 18:43:47 -08:00
Interaction
Updates for haste2 inside of jest
2016-01-08 06:52:29 -08:00
JavaScriptAppEngine
Disable Flow on Packager
2016-01-27 15:33:31 -08:00
LayoutAnimation
Wrapped UIManager native module for better abstraction
2015-11-27 07:00:32 -08:00
Linking
Add cross-platform Linking module
2016-01-26 14:34:31 -08:00
LinkingIOS
Add cross-platform Linking module
2016-01-26 14:34:31 -08:00
Modal
Improve Modal docs describing iOS only support
2015-12-05 18:48:28 -08:00
NativeApp
Decouple Module System from Native Calls
2015-12-08 16:03:37 -08:00
Network
bind this in onreadystatechange call
2016-01-18 08:55:35 -08:00
Picker
Added support for styling the PickerIOS
2015-12-08 07:48:26 -08:00
Portal
Wrapped UIManager native module for better abstraction
2015-11-27 07:00:32 -08:00
PullToRefresh
Added ColorPropType
2015-12-23 10:08:38 -08:00
PushNotificationIOS
Made Map & Set polyfills available globally
2016-01-20 08:27:38 -08:00
QuickPerformanceLogger
added QPL for main interactions
2015-09-29 22:25:23 -07:00
RCTTest
Replace direct access of NativeModules.UIManager with require('UIManager')
2016-01-30 07:36:34 -08:00
react-native
Add a cross-platform Picker
2016-01-29 03:59:54 -08:00
ReactIOS
Reimplement color processing
2016-01-29 09:13:32 -08:00
ReactNative
Deploy v0.20.1
2015-12-18 17:04:29 -08:00
RKBackendNode
Wrapped UIManager native module for better abstraction
2015-11-27 07:00:32 -08:00
Sample
…
Settings
Replaced RegExp method parser with recursive descent
2015-12-10 10:12:29 -08:00
Storage
Batch AsyncStorage.multiGet calls
2015-12-03 09:10:29 -08:00
StyleSheet
ColorPropTypes support for isRequired and more precise description
2016-02-01 12:47:32 -08:00
Text
Added support for auto-resizing text fields
2016-01-25 05:46:29 -08:00
Utilities
Hot Loading Indicators
2016-02-01 12:42:33 -08:00
vendor
Reimplement color processing
2016-01-29 09:13:32 -08:00
Vibration
…
WebSocket
Added an optional options parameter for WebSockets
2016-01-20 11:01:39 -08:00
Promise.js
Add support for promise rejection tracking
2016-01-07 12:02:56 -08:00