react-native

mirror of https://github.com/status-im/react-native.git synced 2025-01-14 11:34:23 +00:00

History

Steve Kellock f49093f397 Fixes launching Visual Studio Code due to args being a nested array.

Summary:
**Motivation**

Visual Studio Code appears to have been accidentally borked in RN 38 & 39.

[Here you see](a643784144 (diff-9ad1aafc931637a94d74b60c06b46871R153)) args become an array to support the new `shell-quote` support.

Problem is, `getArgumentsForLineNumber` also returns an array.

[And because we](a643784144 (diff-9ad1aafc931637a94d74b60c06b46871R161)) `push` instead of `concat`, we get hawt array-on-array action.

Surprisingly Atom works.  But Code doesn't like this at all.

**Test plan (required)**

On RN 0.38 and 0.39, what's happening when I click on the simulator stack frame, Code opens with the array as a string...

![image](https://cloud.githubusercontent.com/assets/68273/20971724/83a3d7c4-bc60-11e6-8170-a1c2a4adee60.png)

I've tested Vim, Code and Atom (all on 10.11.6) as well as all combinations of `REACT_EDITOR` both set
Closes https://github.com/facebook/react-native/pull/11345

Differential Revision: D4339963

Pulled By: lacker

fbshipit-source-id: 030cb9e3d84fd6861f28e3652bebfe2eef28dd62

2016-12-16 10:28:35 -08:00

__mocks__

Fix lint in local-cli

2016-11-14 11:13:42 -08:00

bundle

fbsource

2016-12-13 18:58:34 -08:00

core

react-native link (aka rnpm) support for Windows

2016-12-10 16:58:28 -08:00

dependencies

BREAKING: expose getTransformOptions directly in configuration