status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/React
History
Martin Arista 47b36d3ff0 Update DevLoadingView to Support iPhone X 
Summary:
The current implementation of DevLoadingView for iPhone currently gives a static height of `22` and does not take into account iPhoneX screen dimensions.

Devices: All iPhone devices currently available with Xcode v9.2
SDK: 8.1, 9, 10, 11

Validate resize only occurs on iPhone X devices and others remain consistent.

Before:
![feb-10-2018 12-30-20](https://user-images.githubusercontent.com/1743953/36065313-7b41f2ea-0e5e-11e8-87f2-928e26536077.gif)

After:
![feb-10-2018 12-28-15](https://user-images.githubusercontent.com/1743953/36065317-848e4f7e-0e5e-11e8-8aab-70cb5db32f31.gif)

[GENERAL][ENHANCEMENT][{React}] - Improvements to DevLoadingView for iPhone X
Closes https://github.com/facebook/react-native/pull/17936

Differential Revision: D6962962

Pulled By: shergin

fbshipit-source-id: e11d9386544fe19a9195e22a03e12f64e934cad7
 		2018-02-11 22:49:21 -08:00
..
Base Delete RCTBatchedBridge 2018-02-05 12:02:35 -08:00
CxxBridge Native Modules -> Native Extensions 2018-02-07 08:07:13 -08:00
CxxModule Make RCTNativeModule::invokeInner explicitely return folly::none in case of error 2017-11-17 03:17:20 -08:00
CxxUtils More efficient dynamic->NSString conversion. 2017-07-26 18:31:12 -07:00
DevSupport Update DevLoadingView to Support iPhone X 2018-02-11 22:49:21 -08:00
Fabric iOS: Added scaffolding for FabricUIManager native module 2018-02-06 21:49:37 -08:00
Inspector Implement bundle sync status 2018-02-01 06:18:13 -08:00
Modules always create debugger websocket connection 2018-02-08 10:29:40 -08:00
Profiler Bunch of utility funcs were moved to RCTUIManagerUtils 2017-09-26 14:08:28 -07:00
React.xcodeproj Delete RCTBatchedBridge 2018-02-05 12:02:35 -08:00
UIUtils Migrate DeviceInfoModule from RN Module to Native Function. 2018-01-29 11:18:42 -08:00
Views Enabling round-to-pixel Yoga feature for RN (iOS) 2018-02-05 22:17:22 -08:00
third-party.xcconfig More attempts to fix Travis CI runs 2017-05-10 04:32:54 -07:00