mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 17:15:54 +00:00
516bf7bd94
Summary: The `EmitterSubscription.remove()` method was previously calling `this.subscriber.removeSubscription(this)` directly, bypassing the mechanism in `NativeEventEmitter` that keeps track of the number of subscriptions. This meant that native event modules (subclasses of `RCTEventEmitter`) would keep sending events even after all the listeners had been removed. This wasn't a huge overhead, since these modules are singletons and only send one message over the bridge per event, regardless of the number of listeners, but it's still undesirable. This fixes the problem by routing the `EmitterSubscription.remove()` method through the `EventEmitter` so that `NativeEventEmitter` can apply the additional native calls. I've also improved the architecture so that each `NativeEventEmitter` uses its own `EventEmitter`, but they currently all still share the same `EventSubscriptionVendor` so that legacy code which registers events via `RCTDeviceEventEmitter` still works. Reviewed By: vjeux Differential Revision: D3292361 fbshipit-source-id: d60e881d50351523d2112473703bea826641cdef
43 lines
1.0 KiB
JavaScript
43 lines
1.0 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*
|
|
* @providesModule EventSubscription
|
|
* @flow
|
|
*/
|
|
'use strict';
|
|
|
|
import type EventSubscriptionVendor from 'EventSubscriptionVendor';
|
|
|
|
/**
|
|
* EventSubscription represents a subscription to a particular event. It can
|
|
* remove its own subscription.
|
|
*/
|
|
class EventSubscription {
|
|
|
|
eventType: string;
|
|
key: number;
|
|
subscriber: EventSubscriptionVendor;
|
|
|
|
/**
|
|
* @param {EventSubscriptionVendor} subscriber the subscriber that controls
|
|
* this subscription.
|
|
*/
|
|
constructor(subscriber: EventSubscriptionVendor) {
|
|
this.subscriber = subscriber;
|
|
}
|
|
|
|
/**
|
|
* Removes this subscription from the subscriber that controls it.
|
|
*/
|
|
remove() {
|
|
this.subscriber.removeSubscription(this);
|
|
}
|
|
}
|
|
|
|
module.exports = EventSubscription;
|