7d1981ef82
Summary: After execution of `scripts/ios-install-third-party.sh` a symlink is created : `<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver` that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver` This can be executed indirectly by `react-native run-ios`. This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice. Once the `test-driver` symlink is created android app release is failing, for : `./gradlew assembleRelease` the `:app:bundleReleaseJsAndAssets` returns : ``` FAILURE: Build failed with an exception. * What went wrong: Could not list contents of '<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link. ``` Related issues: https://github.com/facebook/react-native/issues/14417 https://github.com/facebook/react-native/issues/14464 https://github.com/facebook/react-native/issues/14548 1. Create new project with `react-native init <YOUR-APP>` 2. cd `<YOUR-APP>/` 3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed. 4. cd `android/` 5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists) IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released. The proper cleanup of files generated by autotools was already applied : https://github.com/google/glog/pull/188 Please let me know if I should provide more details : javache, mhorowitz, hramos Closes https://github.com/facebook/react-native/pull/14638 Differential Revision: D5292362 Pulled By: javache fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e |
||
|---|---|---|
| .. | ||
| android-e2e-test.js | ||
| bump-oss-version.js | ||
| circle-ci-android-setup.sh | ||
| ios-configure-glog.sh | ||
| ios-install-third-party.sh | ||
| launchPackager.bat | ||
| launchPackager.command | ||
| objc-test-ios.sh | ||
| objc-test-tvos.sh | ||
| objc-test.sh | ||
| packager.sh | ||
| process-podspecs.sh | ||
| publish-npm.js | ||
| react-native-xcode.sh | ||
| run-android-ci-instrumentation-tests.js | ||
| run-android-emulator.sh | ||
| run-android-local-integration-tests.sh | ||
| run-android-local-unit-tests.sh | ||
| run-ci-e2e-tests.js | ||
| run-instrumentation-tests-via-adb-shell.sh | ||
| sync-css-layout.sh | ||
| test-manual-e2e.sh | ||
| try-n-times.js | ||
| validate-android-device-env.sh | ||
| validate-android-sdk.sh | ||
| validate-android-test-env.sh | ||