mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
4203c9c837
Summary: The problem with `bundleOpts` is that it discards Flow typing, so it prevents reinforcing the integration of `Bundler` into `Server`. This changeset removes the `bundleOpts` to solve that issues. Instead, it makes the options explicit so that there is less uncertaintly. I love making options explicit, because they force callsites to take a consicious decision about what is really needed, making them more robust. They also expose oddities that probably needs refatoring, for example having a `resolutionRequest` in the bundle options does not seem correct, it should be an implementation details. Likewise, `onProgress` should probably be exposed differently, as it does not affect the content of the bundle itself. Reviewed By: davidaurelio Differential Revision: D4697729 fbshipit-source-id: d543870ba024e7588c10b101fa51429c77cc5ddc