mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 09:12:02 +00:00
0e7375ae36
Summary: **Motivation** Fix flickering in TabBarIOS on Apple TV... issue #15081 After this change, on Apple TV, TabBarIOS item selections will be controlled purely from the native side after initial render with the `selected` prop. This is necessary because the `UITabBar` implementation in tvOS moves the selection before calling `shouldSelectViewController:`; this issue does not occur on iOS. **Test plan** Existing CI should still pass. Issue is resolved when testing the example code in #15081 . Closes https://github.com/facebook/react-native/pull/15220 Differential Revision: D5601671 Pulled By: javache fbshipit-source-id: c18e7d3482d6c07d534ff40a443a6f642d4267bb
137 lines
3.3 KiB
Objective-C
137 lines
3.3 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTTabBarItem.h"
|
|
|
|
#import "RCTConvert.h"
|
|
#import "RCTLog.h"
|
|
#import "UIView+React.h"
|
|
|
|
@implementation RCTConvert (UITabBarSystemItem)
|
|
|
|
RCT_ENUM_CONVERTER(UITabBarSystemItem, (@{
|
|
@"bookmarks": @(UITabBarSystemItemBookmarks),
|
|
@"contacts": @(UITabBarSystemItemContacts),
|
|
@"downloads": @(UITabBarSystemItemDownloads),
|
|
@"favorites": @(UITabBarSystemItemFavorites),
|
|
@"featured": @(UITabBarSystemItemFeatured),
|
|
@"history": @(UITabBarSystemItemHistory),
|
|
@"more": @(UITabBarSystemItemMore),
|
|
@"most-recent": @(UITabBarSystemItemMostRecent),
|
|
@"most-viewed": @(UITabBarSystemItemMostViewed),
|
|
@"recents": @(UITabBarSystemItemRecents),
|
|
@"search": @(UITabBarSystemItemSearch),
|
|
@"top-rated": @(UITabBarSystemItemTopRated),
|
|
}), NSNotFound, integerValue)
|
|
|
|
@end
|
|
|
|
@implementation RCTTabBarItem{
|
|
UITapGestureRecognizer *_selectRecognizer;
|
|
}
|
|
|
|
@synthesize barItem = _barItem;
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame
|
|
{
|
|
if ((self = [super initWithFrame:frame])) {
|
|
_systemIcon = NSNotFound;
|
|
#if TARGET_OS_TV
|
|
_wasSelectedInJS = NO;
|
|
#endif
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (UITabBarItem *)barItem
|
|
{
|
|
if (!_barItem) {
|
|
_barItem = [UITabBarItem new];
|
|
_systemIcon = NSNotFound;
|
|
}
|
|
return _barItem;
|
|
}
|
|
|
|
- (void)setBadge:(id)badge
|
|
{
|
|
_badge = [badge copy];
|
|
self.barItem.badgeValue = [badge description];
|
|
}
|
|
|
|
- (void)setSystemIcon:(UITabBarSystemItem)systemIcon
|
|
{
|
|
if (_systemIcon != systemIcon) {
|
|
_systemIcon = systemIcon;
|
|
UITabBarItem *oldItem = _barItem;
|
|
_barItem = [[UITabBarItem alloc] initWithTabBarSystemItem:_systemIcon
|
|
tag:oldItem.tag];
|
|
_barItem.title = oldItem.title;
|
|
_barItem.imageInsets = oldItem.imageInsets;
|
|
_barItem.badgeValue = oldItem.badgeValue;
|
|
}
|
|
}
|
|
|
|
- (void)setIcon:(UIImage *)icon
|
|
{
|
|
_icon = icon;
|
|
if (_icon && _systemIcon != NSNotFound) {
|
|
_systemIcon = NSNotFound;
|
|
UITabBarItem *oldItem = _barItem;
|
|
_barItem = [UITabBarItem new];
|
|
_barItem.title = oldItem.title;
|
|
_barItem.imageInsets = oldItem.imageInsets;
|
|
_barItem.selectedImage = oldItem.selectedImage;
|
|
_barItem.badgeValue = oldItem.badgeValue;
|
|
}
|
|
|
|
if (_renderAsOriginal) {
|
|
self.barItem.image = [_icon imageWithRenderingMode:UIImageRenderingModeAlwaysOriginal];
|
|
} else {
|
|
self.barItem.image = _icon;
|
|
}
|
|
}
|
|
|
|
- (void)setSelectedIcon:(UIImage *)selectedIcon
|
|
{
|
|
_selectedIcon = selectedIcon;
|
|
|
|
if (_renderAsOriginal) {
|
|
self.barItem.selectedImage = [_selectedIcon imageWithRenderingMode:UIImageRenderingModeAlwaysOriginal];
|
|
} else {
|
|
self.barItem.selectedImage = _selectedIcon;
|
|
}
|
|
}
|
|
|
|
- (void)setBadgeColor:(UIColor *)badgeColor
|
|
{
|
|
// badgeColor available since iOS 10
|
|
if ([self.barItem respondsToSelector:@selector(badgeColor)]) {
|
|
self.barItem.badgeColor = badgeColor;
|
|
}
|
|
}
|
|
|
|
- (UIViewController *)reactViewController
|
|
{
|
|
return self.superview.reactViewController;
|
|
}
|
|
|
|
#if TARGET_OS_TV
|
|
|
|
// On Apple TV, we let native control the tab bar selection after initial render
|
|
- (void)setSelected:(BOOL)selected
|
|
{
|
|
if (!_wasSelectedInJS) {
|
|
_selected = selected;
|
|
}
|
|
}
|
|
|
|
#endif
|
|
|
|
@end
|