status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/React/Profiler
History
Shruti Malugu edbb48c67a Replacing all instances of [UIApplication sharedApplication] wi… 
Summary:
…th RCTSharedApplication()

Thanks for submitting a PR! Please read these instructions carefully:

- [ ] Explain the **motivation** for making this change.
          Using React Native latest version with Cocoapods 1.2.0 causes the following error inside iOS app extensions

> /react-native/React/Modules/RCTAccessibilityManager.m:67:70: ‘sharedApplication’ is unavailable: not available on iOS (App Extension) — Use view controller based solutions where appropriate instead.

Moving the use of [UIApplication sharedApplication] to RCTSharedApplication() which is safe on app extension

- [ ] Provide a **test plan** demonstrating that the code is solid.
        I am not sure how to test such that all the features which touch the modified code are tested.

- [ ] Match the **code formatting** of the rest of the codebase.
- [ ] Target the `master` branch, NOT a "stable" branch.

What existing problem does the pull request solve?
    Using React Native latest v
Closes https://github.com/facebook/react-native/pull/13227

Differential Revision: D4816338

Pulled By: javache

fbshipit-source-id: e3e3c77882990ad1817b0b633521cff52571ecd0
 		2017-04-01 03:34:41 -07:00
..
RCTFPSGraph.h Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
RCTFPSGraph.m Automated changes to remove implicit capture of self in blocks: Libraries/FBReactKit/BUCK 2016-07-07 12:44:14 -07:00
RCTJSCProfiler.h Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
RCTJSCProfiler.m Tease apart React and RCTBatchedBridge targets 2017-03-21 18:31:23 -07:00
RCTMacros.h Make React Profiler asm position independent 2016-12-08 14:58:26 -08:00
RCTPerfMonitor.m Replacing all instances of [UIApplication sharedApplication] wi… 2017-04-01 03:34:41 -07:00
RCTProfile.h Improve fbsystrace support 2017-03-30 06:53:16 -07:00
RCTProfile.m Replacing all instances of [UIApplication sharedApplication] wi… 2017-04-01 03:34:41 -07:00
RCTProfileTrampoline-arm.S Don't call libc malloc and free directly from assembly 2017-03-16 12:34:06 -07:00
RCTProfileTrampoline-arm64.S Don't call libc malloc and free directly from assembly 2017-03-16 12:34:06 -07:00
RCTProfileTrampoline-i386.S Don't call libc malloc and free directly from assembly 2017-03-16 12:34:06 -07:00
RCTProfileTrampoline-x86_64.S Don't call libc malloc and free directly from assembly 2017-03-16 12:34:06 -07:00