react-native

mirror of https://github.com/status-im/react-native.git synced 2025-02-20 13:18:07 +00:00

History

Héctor Ramos 14e8c1486f Adjust pull-bot configuration for new PR template (#23236 )

Summary:
The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings.

It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE.

Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis.

[GENERAL] [Changed] Adjust pull-bot to handle new PR template.

Tested against this PR (note the non-standard section titles):

```
$ yarn
$ yarn danger pr https://github.com/facebook/react-native/pull/23236

📋 Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i>
-
📋 Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i>
-
📋 Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i>

Found only warnings, not failing the build
✨  Done in 4.86s.
```
Pull Request resolved: https://github.com/facebook/react-native/pull/23236

Differential Revision: D13915716

Pulled By: cpojer

fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a

2019-02-01 02:50:26 -08:00

.babelrc

Move danger to bots directory

2018-01-31 16:42:41 -08:00

dangerfile.js

Adjust pull-bot configuration for new PR template (#23236 )

2019-02-01 02:50:26 -08:00

IssueCommands.txt

Update IssueCommands.txt

2018-05-07 14:30:32 -07:00

package.json

Move danger to bots directory

2018-01-31 16:42:41 -08:00

README.md

Update danger token

2018-02-27 10:01:40 -08:00

README.md

GitHub bots, such as the Danger bot, as well as messages used by the Facebook GitHub bot are all configured in this directory/

Danger

We use Danger JS to perform rudimentary maintenance on the React Native repository.

If you'd like to make changes to the Dangerfile, find an existing PR on the React Native repo and make note of the URL.

Then, run from the React Native root directory:

cd bots
npm install
..
node bots/node_modules/.bin/danger pr https://github.com/facebook/react-native/pull/1

And you will get the responses from parsing the Dangerfile.