mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
e544563bd2
Summary: Corresponding iOS PR: #12275 Respect the withCredentials XMLHttpRequest flag for sending cookies with requests. This can reduce payload sizes where large cookies are set for domains. This should fix #5347. This is a breaking change because it alters the default behavior of XHR. Prior to this change, XHR would send cookies by default. After this change, by default, XHR does not send cookies which is consistent with the default behavior of XHR on web for cross-site requests. Developers can restore the previous behavior by passing `true` for XHR's `withCredentials` argument. **Test plan (required)** Verified in a test app that XHR works properly when specifying `withCredentials` as `true`, `false`, and `undefined`. Also, my team uses this change in our app. Adam Comella Microsoft Corp. Closes https://github.com/facebook/react-native/pull/12276 Differential Revision: D4673646 Pulled By: ericvicenti fbshipit-source-id: 924c230c9df72071b3cf9151c3ac201905ac28a5
94 lines
2.5 KiB
JavaScript
94 lines
2.5 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*
|
|
* @providesModule RCTNetworking
|
|
* @flow
|
|
*/
|
|
'use strict';
|
|
|
|
// Do not require the native RCTNetworking module directly! Use this wrapper module instead.
|
|
// It will add the necessary requestId, so that you don't have to generate it yourself.
|
|
const FormData = require('FormData');
|
|
const NativeEventEmitter = require('NativeEventEmitter');
|
|
const RCTNetworkingNative = require('NativeModules').Networking;
|
|
const convertRequestBody = require('convertRequestBody');
|
|
|
|
import type {RequestBody} from 'convertRequestBody';
|
|
|
|
type Header = [string, string];
|
|
|
|
// Convert FormData headers to arrays, which are easier to consume in
|
|
// native on Android.
|
|
function convertHeadersMapToArray(headers: Object): Array<Header> {
|
|
const headerArray = [];
|
|
for (const name in headers) {
|
|
headerArray.push([name, headers[name]]);
|
|
}
|
|
return headerArray;
|
|
}
|
|
|
|
let _requestId = 1;
|
|
function generateRequestId(): number {
|
|
return _requestId++;
|
|
}
|
|
|
|
/**
|
|
* This class is a wrapper around the native RCTNetworking module. It adds a necessary unique
|
|
* requestId to each network request that can be used to abort that request later on.
|
|
*/
|
|
class RCTNetworking extends NativeEventEmitter {
|
|
|
|
constructor() {
|
|
super(RCTNetworkingNative);
|
|
}
|
|
|
|
sendRequest(
|
|
method: string,
|
|
trackingName: string,
|
|
url: string,
|
|
headers: Object,
|
|
data: RequestBody,
|
|
responseType: 'text' | 'base64',
|
|
incrementalUpdates: boolean,
|
|
timeout: number,
|
|
callback: (requestId: number) => any,
|
|
withCredentials: boolean
|
|
) {
|
|
const body = convertRequestBody(data);
|
|
if (body && body.formData) {
|
|
body.formData = body.formData.map((part) => ({
|
|
...part,
|
|
headers: convertHeadersMapToArray(part.headers),
|
|
}));
|
|
}
|
|
const requestId = generateRequestId();
|
|
RCTNetworkingNative.sendRequest(
|
|
method,
|
|
url,
|
|
requestId,
|
|
convertHeadersMapToArray(headers),
|
|
{...body, trackingName},
|
|
responseType,
|
|
incrementalUpdates,
|
|
timeout,
|
|
withCredentials
|
|
);
|
|
callback(requestId);
|
|
}
|
|
|
|
abortRequest(requestId: number) {
|
|
RCTNetworkingNative.abortRequest(requestId);
|
|
}
|
|
|
|
clearCookies(callback: (result: boolean) => any) {
|
|
RCTNetworkingNative.clearCookies(callback);
|
|
}
|
|
}
|
|
|
|
module.exports = new RCTNetworking();
|