react-native/ReactCommon/fabric/attributedstring
Valentin Shergin 80f7891287 Fabric: Embracing non-trivial default values of some Props
Summary:
@public
This is follow up for D8601600 and D8247652 (the last one has detailed explanation of the problem).
From this commit I propose that we have to follow simple rule:
If some prop has a default value which differs from the default value of its type, we have to specify it as {<value>} in .h file and explicitly in .m file, for all other props the default value must not be specified explicitly (in .h files it must be specified as {}).
The reason is that we have to embrase those cases and establish behaviour: if we change the default value in .h file, it always means that we have to change the value in .cpp file too.

Reviewed By: fkgozali

Differential Revision: D8601776

fbshipit-source-id: 3379aace4e2d72febb2b942a3da1cb24decf54be
2018-06-26 11:48:13 -07:00
..
tests Fabric: New props treatment in `attributedstring` module 2018-05-14 16:03:49 -07:00
AttributedString.cpp Fabric/Text: attributedstring module, the second part 2018-05-07 18:09:06 -07:00
AttributedString.h Fabric/Text: attributedstring module, the second part 2018-05-07 18:09:06 -07:00
BUCK Fix deprecated glob usage. 2018-06-23 18:33:48 -07:00
ParagraphAttributes.cpp Fabric: New props treatment in `core` module 2018-05-14 16:03:49 -07:00
ParagraphAttributes.h Fabric: Embracing non-trivial default values of some Props 2018-06-26 11:48:13 -07:00
TextAttributes.cpp iOS: fix up RNTesterPods 2018-05-16 14:14:41 -07:00
TextAttributes.h Fabric: Using Size instead of Point as textShadowOffset's type 2018-06-08 20:31:40 -07:00
conversions.h Fabric: New props treatment in `attributedstring` module 2018-05-14 16:03:49 -07:00
primitives.h Fabric: New props treatment in `attributedstring` module 2018-05-14 16:03:49 -07:00