status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/scripts/versiontemplates
History
James Ide 7733d40237 Move JS-native version check to its own module + unit tests + prefix Obj-C macro w/RCT 
Summary:
- The version check that ensures the JS and native versions match is now in its own module for two reasons: it is easier to test and it allows react-native-windows to override just this module to implement its own version check (ex: more advanced checks for RNW-specific code).
- Added unit tests for the version checking to specify its behavior more clearly, including parity between dev and prod to avoid prod-only behavior and mitigate SEVs.
- Prefixed the Obj-C `#define` with `RCT_` to conform with other RN globals.
Closes https://github.com/facebook/react-native/pull/16403

Differential Revision: D6068491

Pulled By: hramos

fbshipit-source-id: 2b255b93982fb9d1b655fc62cb17b126bd5a939a
 		2017-10-16 14:30:34 -07:00
..
RCTVersion.h.template Move JS-native version check to its own module + unit tests + prefix Obj-C macro w/RCT 2017-10-16 14:30:34 -07:00
ReactNativeVersion.java.template Validate that JS and Native code versions match for RN releases 2017-09-27 18:31:15 -07:00
ReactNativeVersion.js.template Validate that JS and Native code versions match for RN releases 2017-09-27 18:31:15 -07:00