mirror of
https://github.com/status-im/react-native.git
synced 2025-01-16 20:44:10 +00:00
06b5bda349
Summary:This brings back "Use numeric identifiers when building a bundle", previously backed out. This version passes on the correct entry module name to code that decides transform options. Original Description: Since the combination of node and haste modules (and modules that can be required as both node and haste module) can lead to situations where it’s impossible to decide an unambiguous module identifier, this diff switches all module ids to integers. Each integer maps to an absolute path to a JS file on disk. We also had a problem, where haste modules outside and inside node_modules could end up with the same module identifier. This problem has not manifested yet, because the last definition of a module wins. It becomes a problem when writing file-based unbundle modules to disk: the same file might be written to concurrently, leading to invalid code. Using indexed modules will also help indexed file unbundles, as we can encode module IDs as integers rather than scanning string IDs. Reviewed By: martinbigio Differential Revision: D2855202 fb-gh-sync-id: 9a011bc403690e1522b723e5742bef148a9efb52 shipit-source-id: 9a011bc403690e1522b723e5742bef148a9efb52
79 lines
2.5 KiB
JavaScript
79 lines
2.5 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
'use strict';
|
|
|
|
const mkdirp = require('mkdirp');
|
|
const path = require('path');
|
|
const Promise = require('promise');
|
|
|
|
const writeFile = require('../writeFile');
|
|
const writeSourceMap = require('./write-sourcemap');
|
|
const MAGIC_UNBUNDLE_NUMBER = require('./magic-number');
|
|
const MAGIC_UNBUNDLE_FILENAME = 'UNBUNDLE'; // must not start with a dot, as that won't go into the apk
|
|
const MODULES_DIR = 'js-modules';
|
|
|
|
/**
|
|
* Saves all JS modules of an app as single files
|
|
* The startup code (prelude, polyfills etc.) are written to the file
|
|
* designated by the `bundleOuput` option.
|
|
* All other modules go into a 'js-modules' folder that in the same parent
|
|
* directory as the startup file.
|
|
*/
|
|
function saveAsAssets(bundle, options, log) {
|
|
const {
|
|
'bundle-output': bundleOutput,
|
|
'bundle-encoding': encoding,
|
|
dev,
|
|
'sourcemap-output': sourcemapOutput,
|
|
} = options;
|
|
|
|
log('start');
|
|
const {startupCode, modules} = bundle.getUnbundle({minify: !dev});
|
|
log('finish');
|
|
|
|
log('Writing bundle output to:', bundleOutput);
|
|
const modulesDir = path.join(path.dirname(bundleOutput), MODULES_DIR);
|
|
const writeUnbundle =
|
|
createDir(modulesDir).then( // create the modules directory first
|
|
Promise.all([
|
|
writeModules(modules, modulesDir, encoding),
|
|
writeFile(bundleOutput, startupCode, encoding),
|
|
writeMagicFlagFile(modulesDir),
|
|
])
|
|
);
|
|
writeUnbundle.then(() => log('Done writing unbundle output'));
|
|
|
|
return Promise.all([writeUnbundle, writeSourceMap(sourcemapOutput, '', log)]);
|
|
}
|
|
|
|
function createDir(dirName) {
|
|
return new Promise((resolve, reject) =>
|
|
mkdirp(dirName, error => error ? reject(error) : resolve()));
|
|
}
|
|
|
|
function writeModuleFile(module, modulesDir, encoding) {
|
|
const {code, id} = module;
|
|
return writeFile(path.join(modulesDir, id + '.js'), code, encoding);
|
|
}
|
|
|
|
function writeModules(modules, modulesDir, encoding) {
|
|
const writeFiles =
|
|
modules.map(module => writeModuleFile(module, modulesDir, encoding));
|
|
return Promise.all(writeFiles);
|
|
}
|
|
|
|
function writeMagicFlagFile(outputDir) {
|
|
/* global Buffer: true */
|
|
const buffer = Buffer(4);
|
|
buffer.writeUInt32LE(MAGIC_UNBUNDLE_NUMBER);
|
|
return writeFile(path.join(outputDir, MAGIC_UNBUNDLE_FILENAME), buffer);
|
|
}
|
|
|
|
module.exports = saveAsAssets;
|