History

Héctor Ramos 44878ea9bc Fix code analysis bot failure to post lint warnings on pull requests Summary: The code analysis script takes the results of `eslint .` and filters out any messages for filepaths outside of what is modified in a given pull request. This diff fixes an issue where the bot will fail to post warnings if a pull request contains multiple commits, where the most recent commit is a rebase (e.g. `63c00f20a7` in https://github.com/facebook/react-native/pull/22470). This happens because the script looks for files changed in the most recent commit in a PR. In this diff, we switch to a new GitHub API that returns the list of all files changed by a PR, obviating the need to go through individual commits in a PR to look for changed files. Reviewed By: TheSavior Differential Revision: D13324154 fbshipit-source-id: f9f50028439d1969b0feea65f0b3e8bf75ac1a33	2018-12-05 13:15:56 -08:00
..
README.md	Move danger to bots directory	2018-01-31 16:42:41 -08:00
config.yml	Fix code analysis bot failure to post lint warnings on pull requests	2018-12-05 13:15:56 -08:00

Héctor Ramos 44878ea9bc Fix code analysis bot failure to post lint warnings on pull requests

Summary:
The code analysis script takes the results of `eslint .` and filters out any messages for filepaths outside of what is modified in a given pull request. This diff fixes an issue where the bot will fail to post warnings if a pull request contains multiple commits, where the most recent commit is a rebase (e.g. 63c00f20a7 in https://github.com/facebook/react-native/pull/22470). This happens because the script looks for files changed in the most recent commit in a PR.

In this diff, we switch to a new GitHub API that returns the list of all files changed by a PR, obviating the need to go through individual commits in a PR to look for changed files.

Reviewed By: TheSavior

Differential Revision: D13324154

fbshipit-source-id: f9f50028439d1969b0feea65f0b3e8bf75ac1a33

2018-12-05 13:15:56 -08:00

README.md Move danger to bots directory 2018-01-31 16:42:41 -08:00

config.yml Fix code analysis bot failure to post lint warnings on pull requests 2018-12-05 13:15:56 -08:00

README.md

Circle CI

This directory is home to the Circle CI configuration file. Circle is our continuous integration service provider. You can see the overall status of React Native's builds at https://circleci.com/gh/facebook/react-native

You may also see an individual PR's build status by scrolling down to the Checks section in the PR.