status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/danger
History
Hector Ramos c7a596534f Update Dangerfile, fix flagging IssueCommands.txt changes 
Summary:
The bot was incorrectly flagging PRs that do not touch IssueCommands.txt. This PR fixes the Dangerfile rule.

Verify the warning is generated on a PR that touches IssuesCommands.txt:

```
$ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/15087

> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15087"

{
  fails: [],
  warnings: [
    {
      message: "📋 Test Plan - <i>This PR appears to be missing a Test Plan.</i>"
    },
    {
      message: "❗ Bots - <i>This PR appears to modify the list of people that may issue commands to the GitHub bot.</i>"
    }
  ],
  messages: [],
  markdowns: []
}

```

Verify it does not warn on a PR that does not modify IssueCommands.txt:

```
$ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/15089

> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15089"

{
  fails: [],
  warnings: [],
  messages: [],
  markdowns: []
}
```
Closes https://github.com/facebook/react-native/pull/15090

Differential Revision: D5451092

Pulled By: hramos

fbshipit-source-id: 54f0426871391153db81ab02d3d1b3b7f1e75fac
 		2017-07-19 01:52:45 -07:00
..
.babelrc Adds Danger support 2017-07-18 11:16:46 -07:00
README.md Adds Danger support 2017-07-18 11:16:46 -07:00
dangerfile.js Update Dangerfile, fix flagging IssueCommands.txt changes 2017-07-19 01:52:45 -07:00
package.json Adds Danger support 2017-07-18 11:16:46 -07:00

README.md

If you'd like to make changes to the Dangerfile, find an existing PR and copy the URL.

Then run from the React Native root:

cd danger
npm install
..
node danger/node_modules/.bin/danger pr https://github.com/facebook/react-native/pull/1

And you will get the responses from parsing the Dangerfile.