mirror of
https://github.com/status-im/react-native.git
synced 2025-02-21 13:48:13 +00:00
0407d8c8fd
Summary: The iOS snapshots have been out of date for months, but the failure was not caught in open source's `test_objc` job because `xcpretty` was swallowing the non-zero error code. To fix this, I enabled recording mode in RNTesterSnapshotTests.m temporarily, and re-ran the tests in order to update the snapshots. I've also switched the test device used by Circle CI to iPhone 6s to be consistent with the snapshot tests that run internally at Facebook. Integration tests are not fully fixed yet, but I can confirm the following tests are fixed by this diff: ``` -[RNTesterIntegrationTests testImageSnapshotTest] -[RNTesterIntegrationTests testSimpleSnapshotTest] -[RNTesterSnapshotTests testARTExample] -[RNTesterSnapshotTests testLayoutExample] -[RNTesterSnapshotTests testSliderExample] -[RNTesterSnapshotTests testSwitchExample] -[RNTesterSnapshotTests testTabBarExample] -[RNTesterSnapshotTests testTextExample] -[RNTesterSnapshotTests testViewExample] ``` I've also fixed a few shellcheck warnings in related scripts. Reviewed By: fkgozali Differential Revision: D13506865 fbshipit-source-id: dab985130c2ff3cb9dea19d1f87c8ee65d8c141e
18 lines
481 B
Bash
Executable File
18 lines
481 B
Bash
Executable File
#!/bin/bash
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
# Set terminal title
|
|
echo -en "\\033]0;Metro Bundler\\a"
|
|
clear
|
|
|
|
THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)
|
|
|
|
# shellcheck source=/dev/null
|
|
. "$THIS_DIR/packager.sh"
|
|
|
|
echo "Process terminated. Press <enter> to close the window"
|
|
read -r
|