status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Components
History
Jake Dawkins 6234a5dfa2 Fix iOS Picker Item Colors 
Summary:
I want to resolve #11170 by passing the `color` prop from `PickerIOS.Item` to its implementation.

In `RCTPicker.m`, the label.textColor was already being set and used, but there was nothing referencing the past prop. I passed the prop to the implementation, checked if it exists, and if not, set the default color, like before.

I visually tested the **Colorful Pickers** example in UIExplorer. Those picker `Item`s pass in a `color` prop.

![dec-01-2016 22-07-46](https://cloud.githubusercontent.com/assets/9259509/20821696/ae45d704-b812-11e6-9720-0045d6c0bcd4.gif)

The basic picker does not pass the color prop to the picker `Item`, and there are no errors. Basic functionality is still in tact:

![dec-01-2016 22-09-35](https://cloud.githubusercontent.com/assets/9259509/20821730/ee544f74-b812-11e6-9294-a1b45e78d9f7.gif)
Closes https://github.com/facebook/react-native/pull/11260

Differential Revision: D4272370

fbshipit-source-id: 5fa33c40526dda59ca2ab527c31351bcd27e5cf3
 		2016-12-03 18:58:29 -08:00
..
ActivityIndicator RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
Clipboard Remove deprecated APIs and modules 2016-10-11 07:43:52 -07:00
DatePicker Stop other views from stealing the responder from PickerIOS and DatePickerIOS 2016-11-07 18:13:53 -08:00
DatePickerAndroid Android datepicker mode configurations added 2016-11-23 04:58:31 -08:00
DrawerAndroid RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
Keyboard relativeKeyboardHeight works wrong in some cases 2016-11-14 11:58:58 -08:00
MapView Add in support for showing annotation callouts by default without the user clicking on the pins 2016-11-20 00:58:28 -08:00
Navigation Expose NavigatorIOS::replaceAtIndex 2016-11-11 12:58:35 -08:00
Picker Fix iOS Picker Item Colors 2016-12-03 18:58:29 -08:00
ProgressBarAndroid RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
ProgressViewIOS RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
RefreshControl RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
ScrollView Fix redundant styles on RefreshControl for Android 2016-11-14 17:58:58 -08:00
SegmentedControlIOS RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
Slider RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
StatusBar Add currentHeight constant to status bar docs 2016-11-05 17:13:29 -07:00
Switch RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
TabBarIOS unselectedItemTintColor property available since iOS10 2016-11-29 12:28:55 -08:00
TextInput iOS: Introduce spellCheck prop to TextInput 2016-11-25 04:28:28 -08:00
TimePickerAndroid Clean unused import modules. 2016-10-16 11:13:40 -07:00
ToastAndroid Add very basic usage example for android toast 2016-09-19 06:43:54 -07:00
ToolbarAndroid RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
Touchable RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00
UnimplementedViews Convert from React.createClass to ES6 classes 2016-07-26 01:13:31 -07:00
View RN: Update React (2/2) 2016-11-04 05:43:44 -07:00
ViewPager RN: Stop Deep Linking `ReactElement` 2016-10-14 18:59:10 -07:00
WebView Expose setAllowUniversalAccessFromFileURLs in Android WebView 2016-11-08 08:43:38 -08:00
Button.js Change require('invariant') to require('fbjs/lib/invariant') 2016-10-16 02:13:52 -07:00
LazyRenderer.js Cleanup: Prefer `React.Element` over `React$?Element` 2016-10-14 08:59:37 -07:00
ScrollResponder.js Fix invariant in scrollResponderZoomTo 2016-11-29 14:43:38 -08:00
StaticContainer.js RN: Change `onlyChild => React.Children.only` 2016-10-14 18:59:10 -07:00
StaticRenderer.js Reverted commit D4027388 2016-10-16 04:13:42 -07:00
Subscribable.js [ReactNative] clean lint for Libraries/Components 2015-05-18 15:54:07 -08:00