mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
c858420b2d
Summary: This diff attempts to fix a number of iOS native animation bugs related to improper node invalidation and a race with view creation. The major issues were presented in #9120 as problems 3 and 3b, but I'll recap here: The invalidation model we use is overly complicated and incomplete. The proper combination of `_needsUpdate` and `_hasUpdated` will result in nodes values being recomputed. However, we do not invalidate nodes in all the places we should, e.g. if we create a new view and attach it to an existing value node (see example in #9120). This diff chooses to remove the `_hasUpdated` flag, and simply relies on the `_needsUpdate` flag to mark a node as dirty. We mark nodes as dirty when they are: - created - updated - attached to new parents - detached from old parents - attached to a view Calling `updateNodeIfNecessary` will, if necessary, compute all invalidated parent values before recomputing the node value. It will then apply the update, and mark the no Closes https://github.com/facebook/react-native/pull/10663 Differential Revision: D4120301 Pulled By: mkonicek fbshipit-source-id: e247afcb5d8c15999b8328c664b9f7e764d76a75
54 lines
1.6 KiB
Objective-C
54 lines
1.6 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTStyleAnimatedNode.h"
|
|
#import "RCTAnimationUtils.h"
|
|
#import "RCTValueAnimatedNode.h"
|
|
#import "RCTTransformAnimatedNode.h"
|
|
|
|
@implementation RCTStyleAnimatedNode
|
|
{
|
|
NSMutableDictionary<NSString *, NSObject *> *_propsDictionary;
|
|
}
|
|
|
|
- (instancetype)initWithTag:(NSNumber *)tag
|
|
config:(NSDictionary<NSString *, id> *)config;
|
|
{
|
|
if ((self = [super initWithTag:tag config:config])) {
|
|
_propsDictionary = [NSMutableDictionary new];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (NSDictionary *)propsDictionary
|
|
{
|
|
return _propsDictionary;
|
|
}
|
|
|
|
- (void)performUpdate
|
|
{
|
|
[super performUpdate];
|
|
|
|
NSDictionary<NSString *, NSNumber *> *style = self.config[@"style"];
|
|
[style enumerateKeysAndObjectsUsingBlock:^(NSString *property, NSNumber *nodeTag, __unused BOOL *stop) {
|
|
RCTAnimatedNode *node = self.parentNodes[nodeTag];
|
|
if (node) {
|
|
if ([node isKindOfClass:[RCTValueAnimatedNode class]]) {
|
|
RCTValueAnimatedNode *parentNode = (RCTValueAnimatedNode *)node;
|
|
[self->_propsDictionary setObject:@(parentNode.value) forKey:property];
|
|
} else if ([node isKindOfClass:[RCTTransformAnimatedNode class]]) {
|
|
RCTTransformAnimatedNode *parentNode = (RCTTransformAnimatedNode *)node;
|
|
[self->_propsDictionary addEntriesFromDictionary:parentNode.propsDictionary];
|
|
}
|
|
}
|
|
}];
|
|
}
|
|
|
|
@end
|