react-native/React
Valentin Schlattinger e592d6f8c7 fix missing selection indicator lines (#18885)
Summary:
This PR is based on https://github.com/facebook/react-native/pull/13342 by pvinis and fixes https://github.com/facebook/react-native/issues/14442.

As suggested in the discussion on the PR mentioned above, I moved the code from `React/Views/RCTPickerManager.m` to the `initWithFrame` function in `React/Views/RCTPicker.m` and verified that it still fixes the problem.

Before the change in this PR the selection indicator lines are missing when the Picker is initially added to the View and only appear after changing to a different Tab and back. This happens both in the Simulator and my real device (iPhone 6S on iOS 11.3).

![beforechange](https://user-images.githubusercontent.com/7568362/38824104-7b294cae-41a8-11e8-8609-7a647ab3adb8.png)

After the change, the indicator lines always appear. I did not notice any side effects of this change when playing around with the Picker in different configurations.

![afterchange](https://user-images.githubusercontent.com/7568362/38824109-82a5b382-41a8-11e8-8af3-ca07c8b2c30e.png)

https://github.com/facebook/react-native/pull/13342 also fixes this issue but appears to be inactive.

[IOS] [BUGFIX] [PickerIOS] - Fixed missing selection indicator lines
Pull Request resolved: https://github.com/facebook/react-native/pull/18885

Differential Revision: D8945483

Pulled By: hramos

fbshipit-source-id: 2b6c6f42559691530b062503feb24bc305f4a8af
2018-07-20 19:01:32 -07:00
..
Base Suppress spurious warning about RCTCxxModule (#19880) 2018-06-26 17:47:28 -07:00
CxxBridge iOS: Avoid double reload event when reloading JS 2018-06-19 18:47:41 -07:00
CxxModule Update license headers for MIT license 2018-02-16 18:31:53 -08:00
CxxUtils Update license headers for MIT license 2018-02-16 18:31:53 -08:00
DevSupport Hiding pre-bundled notification when not on dev mode 2018-07-17 07:17:09 -07:00
Fabric Fabric: Events related classes were moved to separate buck target 2018-07-17 22:53:57 -07:00
Inspector Migrate Android sources to MIT license header 2018-05-31 15:37:30 -07:00
Modules Replace deprecated `UILineBreakModeWordWrap` with `NSLineBreakByWordWrapping` (#19791) 2018-07-15 00:16:32 -07:00
Profiler Update license headers for MIT license 2018-02-16 18:31:53 -08:00
React.xcodeproj Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
UIUtils Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Views fix missing selection indicator lines (#18885) 2018-07-20 19:01:32 -07:00
third-party.xcconfig OSS: upgrade Folly 2016.09.26 => 2016.10.31 2018-04-13 17:33:23 -07:00