status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/local-cli/util
History
Adam Perry 403f356082 Stop yarn error message appearing for Windows users of local-cli 
Summary:
On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, https://github.com/react-community/create-react-native-app/issues/101, https://github.com/react-community/create-react-native-app/issues/113#issuecomment-289185491 for examples of users hitting this in the wild), even though no package management action is being taken.

From what I can tell this is what happens:

* [`local-cli/util/yarn.js` does not ignore stderr on Windows](6fa87134fc/local-cli/util/yarn.js (L25))
* [`local-cli/util/PackageManager.js` calls the above function when it's require'd](6fa87134fc/local-cli/util/PackageManager.js (L20))

For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh
Closes https://github.com/facebook/react-native/pull/13355

Differential Revision: D4848084

Pulled By: hramos

fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
 		2017-04-07 11:17:00 -07:00
..
__mocks__ Revert "Add folders to attempt to unblock sync" 2015-10-26 22:48:10 +00:00
Config.js Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00
PackageManager.js Stop yarn error message appearing for Windows users of local-cli 2017-04-07 11:17:00 -07:00
assertRequiredOptions.js Merge `rnpm cli` into react-native 2016-07-30 09:13:46 -07:00
copyAndReplace.js Rewrite 'react-native init' and 'react-native upgrade' without using Yeoman in preparation for templates support 2016-11-18 18:28:51 -08:00
findSymlinksPaths.js Add symlinks under node_modules as part of projectRoots 2017-01-31 03:43:39 -08:00
isPackagerRunning.js Fix comment typos 2016-06-03 02:43:57 -07:00
isValidPackageName.js Move `private-cli` commands to `local-cli` 2015-10-26 15:36:04 -07:00
log.js Add ability to silence packager logs to stdout 2016-03-15 12:10:31 -07:00
parseCommandLine.js Merge `rnpm cli` into react-native 2016-07-30 09:13:46 -07:00
walk.js Move `private-cli` commands to `local-cli` 2015-10-26 15:36:04 -07:00
yarn.js Stop yarn error message appearing for Windows users of local-cli 2017-04-07 11:17:00 -07:00