mirror of
https://github.com/status-im/react-native.git
synced 2025-02-22 14:18:23 +00:00
0407d8c8fd
Summary: The iOS snapshots have been out of date for months, but the failure was not caught in open source's `test_objc` job because `xcpretty` was swallowing the non-zero error code. To fix this, I enabled recording mode in RNTesterSnapshotTests.m temporarily, and re-ran the tests in order to update the snapshots. I've also switched the test device used by Circle CI to iPhone 6s to be consistent with the snapshot tests that run internally at Facebook. Integration tests are not fully fixed yet, but I can confirm the following tests are fixed by this diff: ``` -[RNTesterIntegrationTests testImageSnapshotTest] -[RNTesterIntegrationTests testSimpleSnapshotTest] -[RNTesterSnapshotTests testARTExample] -[RNTesterSnapshotTests testLayoutExample] -[RNTesterSnapshotTests testSliderExample] -[RNTesterSnapshotTests testSwitchExample] -[RNTesterSnapshotTests testTabBarExample] -[RNTesterSnapshotTests testTextExample] -[RNTesterSnapshotTests testViewExample] ``` I've also fixed a few shellcheck warnings in related scripts. Reviewed By: fkgozali Differential Revision: D13506865 fbshipit-source-id: dab985130c2ff3cb9dea19d1f87c8ee65d8c141e
31 lines
817 B
Bash
31 lines
817 B
Bash
# These should match the recommended versions listed in
|
|
# https://facebook.github.io/react-native/docs/getting-started.html
|
|
|
|
|
|
## ANDROID ##
|
|
# Android SDK Build Tools revision
|
|
export ANDROID_SDK_BUILD_TOOLS_REVISION=28.0.2
|
|
# Android API Level we build with
|
|
export ANDROID_SDK_BUILD_API_LEVEL="28"
|
|
# Google APIs for Android level
|
|
export ANDROID_GOOGLE_API_LEVEL="23"
|
|
# Minimum Android API Level we target
|
|
export ANDROID_SDK_TARGET_API_LEVEL="19"
|
|
# Android Virtual Device name
|
|
export AVD_NAME="testAVD"
|
|
# ABI to use in Android Virtual Device
|
|
export AVD_ABI=x86
|
|
|
|
## IOS ##
|
|
export IOS_TARGET_OS="12.1"
|
|
export IOS_DEVICE="iPhone 6s"
|
|
export TVOS_DEVICE="Apple TV"
|
|
|
|
## CI OVERRIDES ##
|
|
# Values to override when running in CI
|
|
# $CI is set by Circle CI
|
|
if [ $CI ]; then
|
|
# Use ARM on Circle CI
|
|
export AVD_ABI=armeabi-v7a
|
|
fi
|