status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-10 09:35:48 +00:00
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Toby Cox 1a62b66c51 FIX #9751 - Cancelling offscreen image loads causing crashes 
Summary:
This fixes https://github.com/facebook/react-native/issues/9751

We were seeing the same issues as the original reporter.

I'm not an expert on this code, so apologies if it's naive, but we haven't seen the crash since making this change.

From my understanding of it, it seems like the `cancelLoad` block was being released before the block returned by `_loadImageOrDataWithURLRequest:` was called.
This PR checks the `cancelled` flag before calling `cancelLoad()`.
Closes https://github.com/facebook/react-native/pull/10016

Differential Revision: D3902723

Pulled By: javache

fbshipit-source-id: 75cd115e28694105c6fc29469986998ca0d4cd09
2016-09-21 14:28:43 -07:00
..
ActionSheetIOS
ActionSheetIOS - Pass URL, not file contents to UIActivityViewController for file URLs.
2016-09-06 04:43:36 -07:00
AdSupport
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
Animated
Removing automatically reset modules between test run
2016-09-19 12:43:55 -07:00
AppRegistry
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
AppState
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
ART
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
BatchedBridge
Remove additional JSON encoding for native->JS communication
2016-09-19 04:44:12 -07:00
BugReporting
Unrevert D3518381
2016-07-06 12:58:41 -07:00
CameraRoll
Add partial image loading to RCTImageView
2016-09-21 12:14:09 -07:00
Components
Active opacity for TouchableHighlight should be 0.85 to match iOS native look
2016-09-21 07:13:38 -07:00
CustomComponents
Prevent 1st breadcrumb from stealing touches from title
2016-09-20 14:13:30 -07:00
DebugComponentHierarchy
Move React Core Integration to a Dependency
2016-04-21 09:28:23 -07:00
Devtools
Get server host in setupDevtools for Android
2016-07-19 05:58:29 -07:00
EventEmitter
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
Experimental
Use Batchinator in WindowedListView
2016-09-06 22:43:27 -07:00
Fetch
Fixed what fetch.js exports
2016-07-14 11:13:27 -07:00
Geolocation
- Add ability to detect if location was mocked
2016-09-20 05:59:04 -07:00
Image
FIX #9751 - Cancelling offscreen image loads causing crashes
2016-09-21 14:28:43 -07:00
Inspector
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
Interaction
Add missing return, FIX #9886
2016-09-15 22:43:36 -07:00
JavaScriptAppEngine
Fix symbolication outside of chrome debugging
2016-09-19 10:58:40 -07:00
LayoutAnimation
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
Linking
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
LinkingIOS
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
Modal
Allow <Modal /> to be presented in different orientations
2016-09-07 13:10:11 -07:00
NativeAnimation
Add support for DiffClamp node
2016-09-06 15:43:35 -07:00
NavigationExperimental
Clean up unused mock for NavigationRootContainer
2016-09-18 17:58:38 -07:00
Network
For file uploads, don't stomp on developer's Content-Type header
2016-09-05 14:58:40 -07:00
PermissionsAndroid
Docs fix: remove confusing typo
2016-09-19 14:46:12 -07:00
PushNotificationIOS
registration error event
2016-09-06 11:13:40 -07:00
QuickPerformanceLogger
AdsManager now uses new react native QPL identifiers
2016-07-20 07:28:36 -07:00
RCTTest
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
react-native
Remove react-native.js.flow
2016-09-14 02:58:40 -07:00
ReactIOS
Deploy v0.32.0
2016-09-06 13:43:47 -07:00
ReactNative
Move React Core Integration to a Dependency
2016-04-21 09:28:23 -07:00
RKBackendNode
Move React Core Integration to a Dependency
2016-04-21 09:28:23 -07:00
Sample
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
Settings
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
Share
Add Share module
2016-07-25 03:43:29 -07:00
Storage
Auto-fix lint errors
2016-08-09 06:43:46 -07:00
StyleSheet
Reverted commit D3855801
2016-09-14 11:28:34 -07:00
Text
Include CSSLayout.h consistently with other project includes
2016-09-06 09:13:39 -07:00
Utilities
Remove additional JSON encoding for native->JS communication
2016-09-19 04:44:12 -07:00
vendor
Cleanup clear/set/throwImmediate
2016-08-12 07:28:38 -07:00
Vibration
Update React Native minimum OS version to iOS8
2016-09-01 19:43:47 -07:00
WebSocket
Updating Websocket readyState in case of websocketFailed event
2016-09-08 17:13:45 -07:00
Promise.js
Make onUnhandled safe for undefined errors
2016-08-02 07:58:28 -07:00
promiseRejectionIsError.js
Add possibility to console.error/redbox on promise rejections
2016-03-15 05:22:22 -07:00