status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Components/ScrollView
History
Chris Knepper cc1a4b0915 Clarify documentation for ScrollView component 
Summary:
The documentation for the prop `scrollEnabled` on the `ScrollView` component does not clarify that scrolling is still possible by calling `scrollTo` on the view ref.

Please see [this expo snack demo](https://snack.expo.io/BJKTVMM-Z) showing scrolling is allowed while `scrollEnabled` is `false`.

This PR makes the documentation for this prop more clear, in that setting it to false will only disable scrolling by touches, not universally.

In my opinion, this also raises the question of a need for an additional prop which would disable all scrolling, even when calling `scrollTo`.

I have attached a screenshot of what this part of the documentation looks like with my edit:

![screen shot 2017-05-23 at 3 38 59 pm](https://cloud.githubusercontent.com/assets/4976096/26374045/e73a035e-3fd1-11e7-93cd-3617c4ac4db8.png)
Closes https://github.com/facebook/react-native/pull/14140

Differential Revision: D5138593

Pulled By: shergin

fbshipit-source-id: db1a5f9c8ac41ecfce952e7b1fce9428b2068162
 		2017-05-26 12:48:37 -07:00
..
__mocks__ Include props in new ListView and ScrollView mocks 2017-01-12 10:58:29 -08:00
ScrollView.js Clarify documentation for ScrollView component 2017-05-26 12:48:37 -07:00
ScrollViewStickyHeader.js fix stickySectionHeader re-render issue 2017-05-22 03:30:27 -07:00
processDecelerationRate.js Removed unnecessary exportedConstants 2016-03-10 10:21:34 -08:00