status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Components
History
Peter Pistorius 185948604c Fix scalesPageToFit default property for iOS WebView. 
Summary:
`scalesPageToFit`'s [documented default value is true](https://github.com/facebook/react-native/blob/master/Libraries/Components/WebView/WebView.ios.js#L318), but it's not explicitly set anywhere on iOS. On Android it's [set to true in defaultProps](https://github.com/facebook/react-native/blob/master/Libraries/Components/WebView/WebView.android.js#L203). This pull-request add the default behaviour.

```
import { WebView } from 'react-native;
/* ... */
<WebView source={{ uri: 'https://google.com' }} />
```

You should be able to zoom in and out using the pinch gesture.

1. Does the reviewer have any additional thoughts around the rest of the defaultProps which aren't explicitly set?
2. Does the reviewer have any additional thoughts on how these two components (iOS/ Android) can share more code?
Closes https://github.com/facebook/react-native/pull/14363

Differential Revision: D5345883

Pulled By: shergin

fbshipit-source-id: e7b9b89f13d6adcdc705244871e00b7a5da52c64
 		2017-06-29 01:00:39 -07:00
..
AccessibilityInfo iOS: Introduce API for making screen reader announcements 2017-05-30 04:46:08 -07:00
ActivityIndicator Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
AppleTV Update remaining PropTypes references 2017-06-12 16:03:09 -07:00
Clipboard Remove deprecated APIs and modules 2016-10-11 07:43:52 -07:00
DatePicker Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
DatePickerAndroid Fixed a typo in open function documentation 2017-04-18 15:36:20 -07:00
DrawerAndroid Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
Keyboard Keyboard will show documentation 2017-06-19 11:06:33 -07:00
Navigation Fixed typo in NavigatorIOS.ios.js 2017-06-13 08:31:37 -07:00
Picker react@16 did away with PropTypes; require prop-types instead 2017-06-22 13:49:57 -07:00
ProgressBarAndroid ProgressBarAndroid checks indeterminate prop type manually 2017-05-10 05:16:06 -07:00
ProgressViewIOS Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
RefreshControl Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
ScrollView warn when setting pagingEnabled when snapToInterval at the same time 2017-06-27 16:22:45 -07:00
SegmentedControlIOS Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
Slider Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
StatusBar Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
Switch Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
TabBarIOS Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
TextInput Fixed an incorrect word in the blurTextInput() documentation. 2017-06-20 19:31:29 -07:00
TimePickerAndroid Clean unused import modules. 2016-10-16 11:13:40 -07:00
ToastAndroid Add very basic usage example for android toast 2016-09-19 06:43:54 -07:00
ToolbarAndroid Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
Touchable remove disableAutomock from jest tests (new default) @bypass-lint 2017-06-13 15:04:09 -07:00
UnimplementedViews Make UnimplementedView invisible in prod 2017-06-06 09:45:15 -07:00
View Remove RN fiber createClass wrapper around View 2017-06-21 12:38:06 -07:00
ViewPager Fixed bad ReactPropTypes reference in ViewPagerAndroid 2017-04-13 15:00:24 -07:00
WebView Fix scalesPageToFit default property for iOS WebView. 2017-06-29 01:00:39 -07:00
Button.js Clearer code in Button.js 2017-06-27 11:33:34 -07:00
LazyRenderer.js Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
ScrollResponder.js Add support for flashScrollIndicators on iOS 2017-06-06 13:06:48 -07:00
StaticContainer.react.js Rename files to match @providesModule annotations 2017-02-03 15:58:58 -08:00
StaticRenderer.js Ran PropTypes -> prop-types codemod against Libraries/FBReactKit/js/react-native-github 2017-04-12 16:15:15 -07:00
Subscribable.js [ReactNative] clean lint for Libraries/Components 2015-05-18 15:54:07 -08:00