status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/CameraRoll
History
Abhinandan 82af7c989b Fix for crash when height or width is nil (#20454) 
Summary:
This PR fixes the issue of height/width being nil in line no 128 of RCTImagePickerManager.m .
`    [self _dismissPicker:picker args:tempImageTag ? @[tempImageTag, height, width] : nil];
`
Fixes#20411

Test Plan
----------
To verify the fix , please make the changes to make either height, width or both `nil `
 in `- (void)imagePickerController:(UIImagePickerController *)picker
didFinishPickingMediaWithInfo:(NSDictionary<NSString *, id> *)info` function of RCTImagePickerManager.m , run the code , you will see the error saying , one of the argument is nil from the array .

![crashscenario](https://user-images.githubusercontent.com/763696/43397014-133ae8fc-9421-11e8-9730-c5906cb8dbea.png)

![crashhandledscenario](https://user-images.githubusercontent.com/763696/43397012-130e42f2-9421-11e8-80fc-cb1abaf8197c.png)

Now run the code with the fix , it will not crash .

Release Notes:
--------------
[IOS][BUGFIX][RCTImagePickerManager] - Change in RCTImagePickerManager to handle crashes if height/width is nil .
Pull Request resolved: https://github.com/facebook/react-native/pull/20454

Differential Revision: D9061059

Pulled By: hramos

fbshipit-source-id: b17f58e411f97f9b904cca0de6c151312c732972
 		2018-07-30 11:17:08 -07:00
..
RCTCameraRoll.xcodeproj Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
CameraRoll.js Remove @providesModule from all modules 2018-04-25 07:37:10 -07:00
ImagePickerIOS.js Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
RCTAssetsLibraryRequestHandler.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTAssetsLibraryRequestHandler.m AssetsLibrary.framework --> Photos.framework; ReactNative stuff 2018-06-19 13:32:16 -07:00
RCTCameraRollManager.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTCameraRollManager.m AssetsLibrary.framework --> Photos.framework; ReactNative stuff 2018-06-19 13:32:16 -07:00
RCTImagePickerManager.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTImagePickerManager.m Fix for crash when height or width is nil (#20454) 2018-07-30 11:17:08 -07:00
RCTPhotoLibraryImageLoader.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTPhotoLibraryImageLoader.m Update license headers for MIT license 2018-02-16 18:31:53 -08:00