mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 09:12:02 +00:00
1e52ef23e7
Summary: Hi, While implementing my own `RCTURLRequestHandler` I came across retain cycles in `RCTNetworkTask` when used with `RCTFileRequestHandler` and `RCTDataRequestHandler`. The `NSBlockOperation` used in `RCTFileRequestHandler` and `RCTDataRequestHandler` could never be dealloc'ed because of a retain cycle. And then the second issue was that those blocks were also strongly capturing the passed delegate which in this case is the `RCTNetworkTask` itself and then since the task was storing the block as a `requestToken`, the task could never be dealloc'ed as well. Here are my proposed fixes. Let me know what you think. Closes https://github.com/facebook/react-native/pull/3884 Reviewed By: svcscm Differential Revision: D2615353 Pulled By: nicklockwood fb-gh-sync-id: a73cbecffbebea75aaeb23d39f04a0d87602926f
42 lines
1.7 KiB
Objective-C
42 lines
1.7 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
|
|
#import "RCTURLRequestDelegate.h"
|
|
#import "RCTURLRequestHandler.h"
|
|
|
|
typedef void (^RCTURLRequestCompletionBlock)(NSURLResponse *response, NSData *data, NSError *error);
|
|
typedef void (^RCTURLRequestCancellationBlock)(void);
|
|
typedef void (^RCTURLRequestIncrementalDataBlock)(NSData *data);
|
|
typedef void (^RCTURLRequestProgressBlock)(int64_t progress, int64_t total);
|
|
typedef void (^RCTURLRequestResponseBlock)(NSURLResponse *response);
|
|
|
|
@interface RCTNetworkTask : NSObject <RCTURLRequestDelegate>
|
|
|
|
@property (nonatomic, readonly) NSURLRequest *request;
|
|
@property (nonatomic, readonly) NSNumber *requestID;
|
|
@property (nonatomic, readonly, weak) id requestToken;
|
|
@property (nonatomic, readonly) NSURLResponse *response;
|
|
@property (nonatomic, readonly) RCTURLRequestCompletionBlock completionBlock;
|
|
|
|
@property (nonatomic, copy) RCTURLRequestProgressBlock downloadProgressBlock;
|
|
@property (nonatomic, copy) RCTURLRequestIncrementalDataBlock incrementalDataBlock;
|
|
@property (nonatomic, copy) RCTURLRequestResponseBlock responseBlock;
|
|
@property (nonatomic, copy) RCTURLRequestProgressBlock uploadProgressBlock;
|
|
|
|
- (instancetype)initWithRequest:(NSURLRequest *)request
|
|
handler:(id<RCTURLRequestHandler>)handler
|
|
completionBlock:(RCTURLRequestCompletionBlock)completionBlock NS_DESIGNATED_INITIALIZER;
|
|
|
|
- (void)start;
|
|
- (void)cancel;
|
|
|
|
@end
|