7 Commits

Author	SHA1	Message	Date
Jagdeep Nagpal	e083f9a139	Fix missing static images when using data binding ... Summary: **Motivation** Images not getting bundled when data binding is enabled in gradle in Android projects. So to fix it running the bundle task before ```dataBindingProcessLayouts``` gradle task **Test plan** Example project with data binding enabled https://github.com/jaggs6/rn_data_binding (master) note in ```app/build.gradle``` ``` dataBinding { enabled = true } ``` when the app is running in debug you will see the following  and when installing and running a release variant (```./gradlew uninstallAll clean installRelease```) you will see this  (note the missing image) to fix this problem I added the fix in react.gradle file and moved it into the project (branch master_working) here is the compare https://github.com/jaggs6/rn_d Closes https://github.com/facebook/react-native/pull/10017 Differential Revision: D3936552 Pulled By: bestander fbshipit-source-id: 9ed9181eb331668de15745b1e06fcf6f79cebb0f	2016-09-28 04:28:38 -07:00
Daniel Braun	b21c8f1614	--reset-cache no longer accept a boolean parameter. ... Summary: The gradle :app:bundleReleaseJsAndAssets task is currently broken on master. Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it. Related: * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 * #9134 * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 Closes https://github.com/facebook/react-native/pull/9163 Differential Revision: D3659300 fbshipit-source-id: 798f211407ee279e9adc98948e94b212da84555a	2016-08-02 16:47:56 -07:00
Ritesh Kadmawala	c0316c695d	Fixed the issue due to which js assets are not bundled in the apk when separate build for different CPU architectures is enabled ... Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes https://github.com/facebook/react-native/pull/8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476	2016-07-10 05:43:20 -07:00
Philipp von Weitershausen	58fb91e62b	Android: allow app/build.gradle to specify how node gets invoked for the packager ... Summary: **Test plan:** With the given patch applied to `react.gradle`, I specified the following in my `android/app/build.gradle`: ``` project.ext.react = [ nodeExecutableAndArgs: ["node", "--max_old_space_size=4096"] ] ``` and ensured in a `./gradlew installDebug --debug` run that the packager gets indeed invoked with these parameters. Closes https://github.com/facebook/react-native/pull/7903 Differential Revision: D3390543 fbshipit-source-id: cf440b36633420b8f67070f47dfabf4c84cb28a7	2016-06-04 15:58:24 -07:00
Philipp von Weitershausen	1f2027a1fe	Android: allow app/build.gradle to specify additional packager arguments ... Summary: If for instance you're using a custom transformer, having this hook will let you specify it without forking all of react.gradle **Test plan:** Specified some additional packager args in my app's `android/app/build.gradle`: ```groovy project.ext.react = [ bundleInDebug: true, extraPackagerArgs: ["--transformer", "path/to/my/transformer.js"] ] ``` and ensured they show up when gradle invokes the bundler. Closes https://github.com/facebook/react-native/pull/7858 Differential Revision: D3382996 Pulled By: mkonicek fbshipit-source-id: 437b2e6c902931d45b9d2f7ec97c833ba0cd3217	2016-06-02 17:28:39 -07:00
Mark Oswald	bb06536616	call bundle with reset-cache true as default from standard project ... Summary: addition to #7297 When called from an upstarting app, the bundling process should always be called with a cleared cache. That avoids possible problems with cached files. Closes https://github.com/facebook/react-native/pull/7324 Differential Revision: D3247420 fb-gh-sync-id: 503ad39cb36455512ccea1af7618e89a80942f0c fbshipit-source-id: 503ad39cb36455512ccea1af7618e89a80942f0c	2016-05-02 08:03:19 -07:00
Satyajit Sahoo	a7cde8045b	Apply react.gradle from node_modules/react-native ... Summary:The goal is to minimize the number of files we need to bootstrap. This allows us to make the upgrade process smoother for everyone. If someone needs to customize the file, we already provide some config options. The ability to copy the file and modify it is always there for those few who need it. **Test plan** Generate a new project with the updated template. The app should build and run fine both in debug and production mode. Related #6292 Closes https://github.com/facebook/react-native/pull/6610 Differential Revision: D3109099 Pulled By: foghina fb-gh-sync-id: 13fc89e60daed30bf6349e532a140c1b6f8f053a fbshipit-source-id: 13fc89e60daed30bf6349e532a140c1b6f8f053a	2016-03-29 07:39:21 -07:00